Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mdt-papyrus.dev] Modeling Assistants & VisualID
Hi Benoit,

Christian replied on Bugzilla, and the change should be safe. I will merge it soon (Probably today), so we have plenty of time to identify potential side effects

Cheers,
Camille

On Tue, Oct 3, 2017 at 2:21 PM, MAGGI Benoit <Benoit.MAGGI@xxxxxx> wrote:

Hi Camille,

 

Did you managed to reach either Christian or Maged?

Christian implemented most of the Assistant framework and Maged was the one to deprecate ModelingAssistantUtil.isVisualID method.

 

Element type representing  stereotypes use qualified name for hint  (Ex: The hint for Requirement ElementType is UML::Class)

Maybe this is the kind non visual hint? Did you test with it ?

 

In any case, I never managed to specialize assistants for a DSML, so SysML 1.4 won’t be impacted.

 

Regards,

Benoit

 

De : mdt-papyrus.dev-bounces@eclipse.org [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx] De la part de Camille Letavernier
Envoyé : jeudi 28 septembre 2017 16:42
À : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : [mdt-papyrus.dev] Modeling Assistants & VisualID

 

Hi all,

 

 

While migrating a project to Oxygen, I've noticed an issue with the model-based Modeling Assistants. If they reference an Element Type with a Semantic Hint, Modeling Assistants are supposed to use that hint to instantiate the proper representation. If the hint is not specified, the Modeling Assistants will generate the cross-product of all possible representations.

 

However, the code is still based on Integer VisualIDs, so in practice, the cross-product will always be generated (Which results in many duplicate assistants). There is a test checking whether the Semantic Hint corresponds to a VisualID pattern (Checking that it is a 4+ digits). I wonder why this test was even required to begin with? Wouldn't it be sufficient to check that there is a non-null, non-empty Semantic Hint, regardless of its actual form?

 

My proposed patch does just that, but since I don't know why the test was initially there, I'd like to confirm that it doesn't break any other customization. Does anyone have an ElementTypeSet using Semantic Hints, which are not used as a visual hint? (If in doubt, please try my patch below [1] [2] [3], and check that your modeling assistants work as expected - with no duplicates, and no missing entry).

 

Also, if someone knows why the VisualID test was initially there, please comment on the Bugzilla, as it might help figuring out if the patch may actually cause bad side effects.

 

 

Thanks,

Camille

 

[1] Bug 525204: [Modeling Assistants] Model-based modeling assistants rely on the deprecated Integer VisualIDs

 

 

--

Camille Letavernier

 

Senior Software Engineer
EclipseSource France

 

Phone: +33 1 85 41 09 21

 

EclipseSource France SAS

Palaiseau-Entreprises

7 rue de la Croix Martre

91120 Palaiseau

 

General Manager: Remi Schnekenburger

Registered Office: 7 rue de la Croix Martre, 91120 Palaiseau, France

Commercial Register 824 977 516  R.C.S. EVRY


_______________________________________________
mdt-papyrus.dev mailing list
mdt-papyrus.dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev



--
Camille Letavernier

Senior Software Engineer
EclipseSource France

Phone: +33 1 85 41 09 21

EclipseSource France SAS
Palaiseau-Entreprises
7 rue de la Croix Martre
91120 Palaiseau

General Manager: Remi Schnekenburger
Registered Office: 7 rue de la Croix Martre, 91120 Palaiseau, France
Commercial Register 824 977 516  R.C.S. EVRY

Back to the top