Hi,
Thanks everyone, for sharing information, proposition and history.
The patch has been merged [1]:
-
no more guava reexport
-
guava dependencies use Import-Package
For the future, please avoid using Guava when the job can be done with Java 8 (and soon 9
J )
Regards,
Benoît
1:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=514332
De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx]
De la part de Camille Letavernier
Envoyé : mercredi 29 mars 2017 14:24
À : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : Re: [mdt-papyrus.dev] Guava conflicts
We enforced require-bundle during the 0.9.x refactoring, because at the time, we had no idea where packages were coming from (Due to inconsistencies between plug-in and package names). Later, this has been enforced
by a JUnit test (In BundleTests). When we first met the issue with Guava, we decided that this restriction wasn't required/helpful anymore, and we removed it (Or commented it out)
If package import is the way to solve the issue, then do not hesitate :)
At some point, we also discussed about replacing all our Guava APIs with Java 8 equivalents. I don't think we use any "Guava-only" class/interface in our public API anymore. However, since these issues/discussions
always seem to occur around M6/M7 (i.e. after API freeze), I think nothing has been done in this direction.
We did also investigate Require-bundle + Reexport, as an alternative to Package Import + Use, but it didn't work. So I guess Java 8 (whenever possible) + Package Import/Use (for all remaining cases) is the way
to go
2017-03-29 13:46 GMT+02:00 Ed Willink <ed@xxxxxxxxxxxxx>:
Hi
Once upon a time it was necessary to use import package to accommodate the migration of com.google.collect between differently named bundles.
It seems to be conventional to import org.apache.log4j and com.ibm.icu.* as packages.
I'm not sure that there is really much difference apart from the anarchic freedom of import-package to be in an unspecified bundle.
Regards
Ed Willink
On 29/03/2017 12:26, Christian Damus wrote:
Hi, Benoit,
If I recall correctly, there used to be checks in a JUnit test class for bundle and feature metadata that assert there were no occurrences of Import-Package headers in any Papyrus bundle manifest. I could be wrong about that. I also seem to recall asking the
reason for it, in the mailing list or in Paris, I'm not sure.
Anyways, I do see some bundles using Import-Package, and the test apparently is not checking it, so if it was policy, then it isn't now? Indeed, the BundlesTests class still has the "importPackage" test method but it is commented out. The doc comment on that
test indicates that importing packages was "discouraged" at some time in the past.
On Mar 29, 2017, 04:08 -0400, MAGGI Benoit
<Benoit.MAGGI@xxxxxx>, wrote:
Hello everyone,
Guava’s conflicts are still present!
The recent bump from 15 to 21 solved internal Papyrus problems but brakes EMF-Compare integration.
All information in the bugtracker [1]
Christian said that we have a policy for only using
required bundle and not imported package. I can’t find a reference for this policy in the wiki
Can someone point it for me?
Please follow and comment the bug if you have any suggestion.
Regards,
Benoît
1:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=514332
_______________________________________________
mdt-papyrus.dev mailing list
mdt-papyrus.dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
_______________________________________________
mdt-papyrus.dev mailing list
mdt-papyrus.dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
_______________________________________________
mdt-papyrus.dev mailing list
mdt-papyrus.dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
|
