Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mdt-ocl.dev] Bug 283660: Fixes for test warnings and new launches

Hi Ed,

True, I've been trying to add tests for the visitor ... but this is way more of a challenge that I first thought and I don't have as much time as I'd like to tackle this. I'll take a look at the patch asap and should be able to give you my feedback today. As a side note, I think test code could be commited without being double-checked as long as no test is removed and all tests continue to pass :).

By the way, one of the test fails for both ecore and uml bindings under my configuration (Debian GNU/Linux 2.6.26-1-686, Java 1.5.0_17, Eclipse 3.5.0 I20090611-1540). Namely RegressionTest#test_hebrew_singleQuote_135321(). I copied the failure stack at the end of this mail. Judging by the comment embedded in the expression which parse fails, I believe it _should_ work under linux but cannot confirm. Anyone knows for sure?

Laurent Goubet
Obeo

junit.framework.AssertionFailedError: Parse failed: Unrecognized variable: (�foo�)
at junit.framework.Assert.fail(Assert.java:47)
at org.eclipse.ocl.ecore.tests.AbstractTestSuite.parseConstraintUnvalidated(AbstractTestSuite.java:319) at org.eclipse.ocl.ecore.tests.AbstractTestSuite.parseUnvalidated(AbstractTestSuite.java:245) at org.eclipse.ocl.ecore.tests.AbstractTestSuite.parse(AbstractTestSuite.java:230) at org.eclipse.ocl.ecore.tests.RegressionTest.test_hebrew_singleQuote_135321(RegressionTest.java:1607)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) at org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:62) at org.eclipse.pde.internal.junit.runtime.CoreTestApplication.run(CoreTestApplication.java:23)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:574) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
at org.eclipse.equinox.launcher.Main.main(Main.java:1287)

Ed Willink a écrit :
Hi

https://bugs.eclipse.org/bugs/show_bug.cgi?id=283660

has been waiting for a +1 for a week.

It's only test code so shall I just commit it?

Laurent: since you've been updating some tests perhaps you could check it.

Ed

_______________________________________________
mdt-ocl.dev mailing list
mdt-ocl.dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mdt-ocl.dev




Back to the top