Re: [mat-dev] MAT Proposal: Add Thread Overview Button

[Kevin Grigorenko <kevin.grigorenko@xxxxxxxxxx>]

Done: https://bugs.eclipse.org/bugs/show_bug.cgi?id=399830

--
Kevin Grigorenko
IBM WAS SWAT Team
kevin.grigorenko@xxxxxxxxxx
Blog: https://www.ibm.com/developerworks/mydeveloperworks/blogs/kevgrig/?lang=en


"Tsvetkov, Krum" ---01/29/2013 12:15:17 AM---Hi Kevin, Thanks for the proposal! I also think that it would be useful to make this functionality m

From:	"Tsvetkov, Krum" <krum.tsvetkov@xxxxxxx>
To:	Memory Analyzer Dev list <mat-dev@xxxxxxxxxxx>,
Date:	01/29/2013 12:15 AM
Subject:	Re: [mat-dev] MAT Proposal: Add Thread Overview Button
Sent by:	mat-dev-bounces@xxxxxxxxxxx

---

Hi Kevin,
 
Thanks for the proposal! I also think that it would be useful to make this functionality more visible.
Could you please open a bugzilla ticket and attach the code there? It is necessary for the IP tracking.
 
Regards,
Krum
 
From: mat-dev-bounces@xxxxxxxxxxx [mailto:mat-dev-bounces@xxxxxxxxxxx] On Behalf Of Kevin Grigorenko
Sent: Donnerstag, 3. Januar 2013 01:34
To: mat-dev@xxxxxxxxxxx
Subject: [mat-dev] MAT Proposal: Add Thread Overview Button

Hi there, Happy New Years.

I've found that I recommend the use of the thread overview plugin very often. It's incredibly useful to do things such as seeing which database queries are running on which threads, finding the stacks of threads that consume too much heap, etc. However, getting to this feature is not obvious: Open Query Browser button > Java Basics > Thread Overview and Stacks, and then I find some novices do not realize that they can just click "Finish" on the dialog that asks for which threads to list.

I think this query is so useful that I propose adding a button to the main UI view. Here's a patch:

Index: src/org/eclipse/mat/ui/snapshot/editor/HeapEditorContributions.java
===================================================================
--- src/org/eclipse/mat/ui/snapshot/editor/HeapEditorContributions.java (revision 1397)
+++ src/org/eclipse/mat/ui/snapshot/editor/HeapEditorContributions.java (working copy)
@@ -31,6 +31,7 @@
    Action openHistogram;

    Action openDominatorTree;

    Action openOQLPane;

+    Action openThreadOverview;



    Action runExpertTest;

    Action openQueries;

@@ -43,6 +44,7 @@
        manager.add(openHistogram);

        manager.add(openDominatorTree);

        manager.add(openOQLPane);

+        manager.add(openThreadOverview);



        manager.add(new Separator());



@@ -66,6 +68,7 @@
        openHistogram = new ExecuteQueryAction(editor, "histogram");//$NON-NLS-1$

        openDominatorTree = new ExecuteQueryAction(editor, "dominator_tree");//$NON-NLS-1$

        openOQLPane = new OpenOQLStudioAction();

+        openThreadOverview = new ExecuteQueryAction(editor, "thread_overview");//$NON-NLS-1$



        runExpertTest = new RunReportsDropDownAction(editor);

        openQueries = new QueryDropDownMenuAction(editor);


--
Kevin Grigorenko
IBM WAS SWAT Team
kevin.grigorenko@xxxxxxxxxx
Blog: https://www.ibm.com/developerworks/mydeveloperworks/blogs/kevgrig/?lang=en_______________________________________________
mat-dev mailing list
mat-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mat-dev