Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-users] Automatic out-of-date configuration updates

For me it's about correctness and usability. If someone changes the source/target level presumably they did so with the intention of correcting an issue (say using a Java 7 language feature and getting an error) and if we know how to correct it I would argue that the correction should be made versus the user having the learn about trying to find the Maven / Update Project option to fix the problem. 

In my example I can't think of a case where I would change the source/target option and not want to be brought to a correct state.

On Nov 9, 2014, at 10:03 AM, Igor Fedorenko <igor@xxxxxxxxxxxxxx> wrote:

The problem with automatic configuration update is not about detecting
if update is safe, but about what happens during the update. Workspace
configuration changes are very expensive in most cases. In your example,
compile level change will trigger full rebuild of the project and any
incremental build of all related projects. Personally, I prefer to have
explicit control over such expensive operations and trigger them manually.

--
Regards,
Igor

On 2014-11-09, 9:22, Jason van Zyl wrote:
Are there conditions under which we can know it's safe? If every Mojo
execution has an associated connector or configuration in the POM to
address its presence can we safely run the update?

After going through the import process we encourage users to address any
inconsistencies in the mappings between their Mojo executions and what
M2Eclipse knows about them. So if this is done and we can
deterministically know it's done would it be safe to just keep projects
in sync, and if not how might address that?

For example if I have a simple project with only a maven-compiler-plugin
configuration and I change the source and target can the update be
safely run? Does the connector know not to just execute if the required
Java language level cannot be satisfied from the environment for
example? And if it's not can that be reported in a way for the user to
correct it?

I can certainly understand how you might not want to run this with a
bunch of random Mojo executions where you haven't spent the time to
setup a mapping configuration, but if the user have we should
deterministically know when we can run the update and do it
automatically and correctly. This would definitely make for a much
better user experience.

On Nov 7, 2014, at 4:36 PM, Fred Bricon <fbricon@xxxxxxxxx
<mailto:fbricon@xxxxxxxxx>> wrote:

Hi,

FYI, I whipped up a small plugin that automatically update out-of-date
project configuration, under our JBoss Tools Playground repo [1].

I'm not sure if it's completely safe to use. There's no preference to
(de)activate it -yet-. The plugin is set to start on workspace startup
for now, which isn't ideal, but if you deactivate it from Preferences
> Startup and Shutdown and restart the workspace, it should be inactive.
It's, most probably, sub-optimally implemented, but it worked on the
small set of projects I tried.

p2 site to install it from is at [2]. Feel free to try it and give
some feedback. Then we can discuss what to do with it, wrt [3].
[1]
https://github.com/jbosstools/jbosstools-playground/tree/master/plugins/org.jboss.tools.playground.maven.autoupdate
[2]
http://download.jboss.org/jbosstools/builds/staging/jbosstools-playground_master/all/repo/
[3] https://bugs.eclipse.org/bugs/show_bug.cgi?id=335720

Fred

--
"Have you tried turning it off and on again" - The IT Crowd
_______________________________________________
m2e-users mailing list
m2e-users@xxxxxxxxxxx <mailto:m2e-users@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-users

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------

Selfish deeds are the shortest path to self destruction.

 -- The Seven Samuari, Akira Kurosawa











_______________________________________________
m2e-users mailing list
m2e-users@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-users

_______________________________________________
m2e-users mailing list
m2e-users@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-users

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/takari_io
---------------------------------------------------------

We know what we are, but know not what we may be.

  -- Shakespeare










Back to the top