Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-users] [m2e-dev] maven installation support rework

I've exposed global settings.xml location in m2e preferences. Existing
configuration should be preserved when upgrading from 1.4, but the value
is not licked to selected/default maven installation.

I don't use global settings.xml myself, so I did only very basic testing
of the UI. Let me know if this approach works for you and/or if I broke
anything ;-)

--
Regards,
Igor

On 2014-04-22, 11:04, Marcel Schutte wrote:
On Tue, Apr 22, 2014 at 4:52 PM, Igor Fedorenko <igor@xxxxxxxxxxxxxx
<mailto:igor@xxxxxxxxxxxxxx>> wrote:



    On 2014-04-22, 10:41, Marcel Schutte wrote:

        Hi Igor,

        I will surely test with your 1.5 SNAPSHOT (but can't do that at work
        because of the non standard http port, sigh).

        However, as I described, we only configure our nexus in the global
        settings.xml and m2e can resolve its content fine. The 'maven
        repositories' view also shows both our repository and mirror
        config, so
        I think that m2e must be using these items.


    I think you are right, global settings.xml is used during artifact
    resolution too. I still don't think coupling default Maven installation
    used to RunAs-MavenBuild and global settings.xml used by m2e is a good
    idea. I'll add explicit global settings.xml to m2e preferences instead.

    https://bugs.eclipse.org/bugs/__show_bug.cgi?id=433224
    <https://bugs.eclipse.org/bugs/show_bug.cgi?id=433224>


This would work for me.


        In your original mail you wrote that calculation of the location
        of the
        local maven repository didn't make much sense. Can you explain
        what you
        mean there? For us it makes good sense to place the local
        repository at
        a non default location, because of windows profile
        synchronisation in
        our domain (imagine your local repository being backup up on every
        windows logon/logoff)


    Do you configure local repository location in global settings.xml?


Yes, we do. Our development team uses a highly standardized setup with
default tool locations and indeed a default local repository location.


    --
    Regards,
    Igor


        Regards, Marcel


        On Tue, Apr 22, 2014 at 4:20 PM, Igor Fedorenko
        <igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>> wrote:

             Unless I am missing something (which is possible) m2e only read
             <default_maven_installation>/____conf/settings.xml when it
        calculated

             local
             repository path. I removed this logic from m2e. Local
        repository
             location only depends on user settings.xml now.

             <maven_installation>/conf/____settings.xml was also used by
        maven during

             RunAs->MavenBuild. This is part of standard maven behaviour
        and is not
             affected.

             Latest m2e 1.5 snapshot can be installed from [1], give it
        a try and let
             me know if this change causes problems in your environment.
        You probably
             want to test with fresh/clean workspace, m2e preferences
        format changed
             and m2e 1.4 will not be able to read installation
        configuration from 1.5
             workspace (1.5 can read 1.4 preferences).


             [1]

        http://repository.takari.io:____8081/nexus/content/sites/m2e.____extras/m2e/1.5.0/N/LATEST/


        <http://repository.takari.io:__8081/nexus/content/sites/m2e.__extras/m2e/1.5.0/N/LATEST/
        <http://repository.takari.io:8081/nexus/content/sites/m2e.extras/m2e/1.5.0/N/LATEST/>>

             --
             Regards,
             Igor




             On 2014-04-22, 10:11, Marcel Schutte wrote:

                 Hi Igor,

                 It depends on what you mean by 'removed support for
        global user
                 settings.xml': did you just remove the path and open
        file preference
                 elements, or won't m2e be reading the
                 <maven_installation>/conf/____settings.xml anymore?


                 The latter would be a problem for us: we have
        standardized maven
                 installation packages where the global settings.xml
        contains the
                 (non
                 standard) path to the local repository and also the
        mirror and
                 repository setup for our nexus instance.

                 In doing this, our user settings.xml can be a minimal
        setup with
                 just a
                 source control username and one or two properties
        containing paths.

                 Regards,
                 Marcel


                 On Tue, Apr 22, 2014 at 3:53 PM, Igor Fedorenko
                 <igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>
        <mailto:igor@xxxxxxxxxxxxxx <mailto:igor@xxxxxxxxxxxxxx>>
                 <mailto:igor@xxxxxxxxxxxxxx
        <mailto:igor@xxxxxxxxxxxxxx> <mailto:igor@xxxxxxxxxxxxxx
        <mailto:igor@xxxxxxxxxxxxxx>>>> wrote:

                      I've just pushed relatively big rework of how m2e
        handles Maven
                      installations. The core of this change is to give
                 installations logical
                      names and make it possible to configure individual
                 installations.
                      Currently only custom core extensions can be
        configured
                 (something I
                      needed for my maven core development work), but we
        can add
                 things like
                      default parameters relatively easily now.

                      Using runtime names also makes launch
        configuration little
                 easier to
                      share. Different developers still need to manually
                 configure maven
                      installations used by shared launch
        configurations, but at
                 least these
                      runtimes do not have to be installed at exactly
        the same
                 location on all
                      development machines.

                      Somewhat controversially, I removed support for
        global user
                 settings.xml
                      file. It was only used to calculate location of
        maven local
                 repository,
                      which didn't make much sense, and it was getting
        in the way
                 of the
                      changes I needed to make to the maven installation
        ui. I do
                 not believe
                      anyone is affected by this, but let me know if I
        missed a
                 usecase and
                      we'll figure out how to bring this back.

                      --
                      Regards,
                      Igor
                      _____________________________________________________

                      m2e-dev mailing list
        m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
        <mailto:m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>>
                 <mailto:m2e-dev@xxxxxxxxxxx
        <mailto:m2e-dev@xxxxxxxxxxx> <mailto:m2e-dev@xxxxxxxxxxx
        <mailto:m2e-dev@xxxxxxxxxxx>>>
        https://dev.eclipse.org/______mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/____mailman/listinfo/m2e-dev>
                 <https://dev.eclipse.org/____mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/__mailman/listinfo/m2e-dev>>



          <https://dev.eclipse.org/____mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/__mailman/listinfo/m2e-dev>
                 <https://dev.eclipse.org/__mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/mailman/listinfo/m2e-dev>>>




                 --
                 Fotografie
        http://schutte.name/


                 ___________________________________________________
                 m2e-dev mailing list
        m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
        <mailto:m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>>
        https://dev.eclipse.org/____mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/__mailman/listinfo/m2e-dev>
                 <https://dev.eclipse.org/__mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/mailman/listinfo/m2e-dev>>

             ___________________________________________________
             m2e-dev mailing list
        m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
        <mailto:m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>>
        https://dev.eclipse.org/____mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/__mailman/listinfo/m2e-dev>
             <https://dev.eclipse.org/__mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/mailman/listinfo/m2e-dev>>




        --
        Fotografie
        http://schutte.name/


        _________________________________________________
        m2e-dev mailing list
        m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
        https://dev.eclipse.org/__mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/mailman/listinfo/m2e-dev>

    _________________________________________________
    m2e-dev mailing list
    m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
    https://dev.eclipse.org/__mailman/listinfo/m2e-dev
    <https://dev.eclipse.org/mailman/listinfo/m2e-dev>




--
Fotografie
http://schutte.name/


_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-dev



Back to the top