Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-users] please test m2e 1.2 changes

Hi Igor,

Is the fact that JDT looks for this file a large problem (or a significant performance hit)?
If so would making this behaviour configurable be an option (if it is at all possible)?

The problem I have is people are manually going in and removing the "exclude **" after importing maven projects so they get the package rendering behaviour they are used to - and we are all in agreement that this is a bad thing to do.
(so I'm going by the 80/20 rule - and there seems to be no other API in which to do this).

Regards,

        /James

> -----Original Message-----
> From: m2e-users-bounces@xxxxxxxxxxx [mailto:m2e-users-
> bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> Sent: 17 August 2012 05:29
> To: m2e-users@xxxxxxxxxxx
> Subject: Re: [m2e-users] please test m2e 1.2 changes
>
> Your patch makes jdt traverse all resource folders looking for .m2e_ignored
> file. Although in theory this should not change the end result, this is definitely a
> change in processing that goes beyond pure visuals.
>
> --
> Regards,
> Igor
>
> On 12-08-16 10:57 AM, Nord, James wrote:
> > No you made a striking comment the resource processing must not be
> handled by JDT.
> >
> > To which I thought I made it clear in the response that the patch __does not
> delegate any processing to JDT__**.
> >
> > **unless you happen to have a file that is called ".m2e_ignored" which would
> be processed by JDT.
> >
> > /James
> >
> >> -----Original Message-----
> >> From: m2e-users-bounces@xxxxxxxxxxx [mailto:m2e-users-
> >> bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> >> Sent: 16 August 2012 15:14
> >> To: m2e-users@xxxxxxxxxxx
> >> Subject: Re: [m2e-users] please test m2e 1.2 changes
> >>
> >> I thought I made it clear in my comment in the bug that the attached
> >> patch is not good enough and there are no plans to accept it.
> >>
> >> For better rendering of resources folders, proper solution likely
> >> will only work with Common Navigator.
> >>
> >> To actually delegate resource processing to jdt builder, it is
> >> necessary to introduce new lifecycle mapping strategy that does not
> >> create
> >> excludes=** filter and suppresses maven-resource-plugin execution.
> >> Complete implementation should also deal with pom.xml resources
> >> includes/excludes configuration.
> >>
> >> --
> >> Regards,
> >> Igor
> >>
> >> On 12-08-16 9:41 AM, Nord, James wrote:
> >>> Bump (with patch)
> >>>
> >>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=356568
> >>>
> >>> /James
> >>>
> >>>> -----Original Message-----
> >>>> From: m2e-users-bounces@xxxxxxxxxxx [mailto:m2e-users-
> >>>> bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> >>>> Sent: 16 August 2012 14:19
> >>>> To: Maven Integration for Eclipse users mailing list; Maven
> >>>> Integration for Eclipse developers mailing list
> >>>> Subject: [m2e-users] please test m2e 1.2 changes
> >>>>
> >>>> We are getting close to finishing m2e 1.2, which we plan to
> >>>> contribute both to Kepler M1 and Juno SR1. Bugzilla query [1] shows
> >>>> the list of the changes in this version and the current snapshot
> >>>> build can be
> >> installed from [2].
> >>>>
> >>>> As usual, please ask any questions you have on the mailing list and
> >>>> report any problems you find either here or through bugzilla.
> >>>>
> >>>> Remember, we can't fix problems we don't know about ;-)
> >>>>
> >>>> [1]
> >>>> https://bugs.eclipse.org/bugs/buglist.cgi?list_id=2636734&query_for
> >>>> ma
> >>>> t=advan
> >>>> ced&product=m2e&target_milestone=Kepler%20M1
> >>>> [2]
> >>>> https://repository.sonatype.org/content/repositories/forge-
> >>>> sites/m2e/1.2.0/N/LATEST/
> >>>>

________________________________


**************************************************************************************
This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the postmaster@xxxxxxx and delete it from your system as well as any copies. The content of e-mails as well as traffic data may be monitored by NDS for employment and security purposes. To protect the environment please do not print this e-mail unless necessary.

NDS Limited. Registered Office: One London Road, Staines, Middlesex, TW18 4EX, United Kingdom. A company registered in England and Wales. Registered no. 3080780. VAT no. GB 603 8808 40-00
**************************************************************************************


Back to the top