Re: [m2e-dev] contributions and tests

[David Green <david.green@xxxxxxxxxxx>]

Fred,

Thanks for the fast reply, and thanks for the pointer to the dev environment docs.

I've added a PR with the corresponding test here: https://github.com/tesla/m2e-core-tests/pull/54

Let me know if there's anything else that I should be doing to move this forward, thanks!

David

On Wed, Nov 15, 2017 at 8:53 AM Fred Bricon <fbricon@xxxxxxxxx> wrote:

Hey David,

as described in [1], tests live in [2]. I'll test your changes later today, but it seems fine at 1st glance.

Thanks for your contribution!

[1] https://www.eclipse.org/m2e/documentation/m2e-development-environment.html

[2] https://github.com/tesla/m2e-core-tests

Fred

On Wed, Nov 15, 2017 at 11:29 AM, David Green <david.green@xxxxxxxxxxx> wrote:

Hi,

I've put together a small contribution to m2e: https://git.eclipse.org/r/#/c/106604/

A couple of questions:

1. I'd like to add a test corresponding to the code change.  Where do the tests live?

2. How do I move this forward (i.e. are there any active committers doing reviews?)

Thanks,

David

--

David Green | VP of Architecture | Tasktop

email: david.green@xxxxxxxxxxx

_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-dev

--

"Have you tried turning it off and on again" - The IT Crowd

And if that fails, then http://goo.gl/tnBgH5

_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-dev

--

David Green | VP of Architecture | Tasktop

email: david.green@xxxxxxxxxxx