Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-dev] Need help for performing support of Apache Tomee in m2e-webby

Hi Rafal,

 

Thank for your answer, I’ve got all things now. I start to submit Patch to Cargo project, and then I give the pull request to Webby.

 

And for information this is the incompatibility API I’ve Listed in Webby with Cargo 1.14.11-SNAPSHOT , the most important is WAR.setExtraClasspath :

 

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.19.0:compile (default-compile) on project org.sonatype.m2e.webby: Compilation

failure: Compilation failure:

[ERROR] m2eclipse-webby\org.sonatype.m2e.webby\src\org\sonatype\m2e\webby\internal\launch\boot\EmbeddedServerBo

oter.java:[130]

[ERROR] dep.setExtraClasspath(extraClasspath.split("\\" + File.pathSeparator));

[ERROR] ^^^^^^^^^^^^^^^^^

[ERROR] The method setExtraClasspath(String[]) is undefined for the type WAR

[ERROR] m2eclipse-webby\org.sonatype.m2e.webby\src\org\sonatype\m2e\webby\internal\launch\WebbyLaunchDelegate.j

ava:[267]

[ERROR] dep.setExtraClasspath(cargo.getRuntimeClasspath());

[ERROR] ^^^^^^^^^^^^^^^^^

[ERROR] The method setExtraClasspath(String[]) is undefined for the type WAR

[ERROR] m2eclipse-webby\org.sonatype.m2e.webby\src\org\sonatype\m2e\webby\internal\launch\EclipseJvmLauncher.ja

va:[31]

[ERROR] public class EclipseJvmLauncher implements JvmLauncher {

[ERROR] ^^^^^^^^^^^^^^^^^^

[ERROR] The type EclipseJvmLauncher must implement the inherited abstract method JvmLauncher.setSpawn(boolean)

[ERROR] m2eclipse-webby\org.sonatype.m2e.webby\src\org\sonatype\m2e\webby\internal\launch\EclipseJvmLauncher.ja

va:[31]

[ERROR] public class EclipseJvmLauncher implements JvmLauncher {

[ERROR] ^^^^^^^^^^^^^^^^^^

[ERROR] The type EclipseJvmLauncher must implement the inherited abstract method JvmLauncher.kill()

[ERROR] 4 problems (4 errors)

 

De : m2e-dev-bounces@xxxxxxxxxxx [mailto:m2e-dev-bounces@xxxxxxxxxxx] De la part de Rafal Krzewski
Envoyé : lundi 13 octobre 2014 11:08
À : Maven Integration for Eclipse developers mailing list
Objet : Re: [m2e-dev] Need help for performing support of Apache Tomee in m2e-webby

 

Hi Thomas,

On 10/13/2014 10:54 AM, COLLIGNON, Thomas wrote:

I’m trying to add Tomee support in Webby. To do this I think the start is to add tome support in Cargo (or have you any other idea?).

You are crrect, Tomee support needs to be added to Cargo first.

 

Can you think it’s possible to update cargo version in Tomee ? (to do this webby must be updated because some API in Cargo have disappear ).

 

I'm not sure what do you mean? Update Cargo version in Webby perhaps? Webby is using an outdated SNAPSHOT version of Cargo and it's probably a good idea to update to a more recent stable release. If Cargo API has changed in an incompatible way, either a workaround needs to be found using the current API or maybe patches need to be provided to Cargo to restore the needed functionality.

I can provide pull request (in cargo and webby) if you think it’s possible.

 

I can review patches on Webby side of things once you are ready. You should start with Tomee support in Cargo though. Good luck!

Cheers,
Rafał

Back to the top