Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-dev] Help with m2e connectors 
I did misread the code. There is logic to skip execution when no
relevant sources have changed.

--
Regards,
Igor

On 2014-10-06, 11:10, CoderPlus Team wrote:

Anton,
Thank you for the wiki link :-)

Igor,
Thanks for all the quick responses and the feedback :)

  maven-remote-resources-plugin has 2 goals,
1. *bundle*(which bundles the resources and creates a manifest xml) and
2. *process*(which retrieves a remote resource bundle and unpacks it
into the configured directory.


I had tried to skip the *bundle *goal during incremental
builds(buildContext.isIncremental()) if the resources haven't changed(by
using the plexus Scanner as described in the wiki page
http://wiki.eclipse.org/M2E_compatible_maven_plugins )
I had tried to skip the *process *goal during incremental builds if the
pom file hasn't changed.
<https://github.com/coderplus/m2e-connector-yuicompressor-maven-plugin/blob/master/core/src/com/coderplus/m2e/yuicompressorcore/CoderPlusBuildParticipant.java#L67>
The other yui configurator is also very similar.

Will this not work?


I will look into the other yuicompressor plugin at
https://github.com/sonatype/yuicompressor-maven-plugin/ :)







On Mon, Oct 6, 2014 at 8:03 PM, Igor Fedorenko <igor@xxxxxxxxxxxxxx
<mailto:igor@xxxxxxxxxxxxxx>> wrote:

    Both participant appear to unconditionally execution underlying mojo
    during incremental build, unless I misread the code. This will
    absolutely certainly result in endless workspace builds. Build
    participants that execute during incremental builds must have logic to
    "skip" builds when there are no interesting resource changes.

    I haven't used remote resources plugin, but for yuicompress I found it
    was easier to implement new maven plugin with proper incremental
    behaviour than to "wrap" net.alchim31.maven plugin. I think I still have
    the code somewhere, if you are interested.

    --
    Regards,
    Igor



    On 2014-10-06, 7:25, CoderPlus Team wrote:

        Hi all,
        Can anyone help me in quickly reviewing the below m2e connectors

        https://github.com/coderplus/__m2e-connector-for-maven-__remote-resources-plugin/blob/__master/core/src/com/coderplus/__m2e/remoteresourcescore/__CoderPlusBuildParticipant.java
        <https://github.com/coderplus/m2e-connector-for-maven-remote-resources-plugin/blob/master/core/src/com/coderplus/m2e/remoteresourcescore/CoderPlusBuildParticipant.java>

        https://github.com/coderplus/__m2e-connector-yuicompressor-__maven-plugin/blob/master/core/__src/com/coderplus/m2e/__yuicompressorcore/__CoderPlusBuildParticipant.java
        <https://github.com/coderplus/m2e-connector-yuicompressor-maven-plugin/blob/master/core/src/com/coderplus/m2e/yuicompressorcore/CoderPlusBuildParticipant.java>

        Can you also help in getting this added to the m2e discovery
        catalog.


        Regards,
        Aneesh


        _________________________________________________
        m2e-dev mailing list
        m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
        To change your delivery options, retrieve your password, or
        unsubscribe from this list, visit
        https://dev.eclipse.org/__mailman/listinfo/m2e-dev
        <https://dev.eclipse.org/mailman/listinfo/m2e-dev>

    _________________________________________________
    m2e-dev mailing list
    m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
    To change your delivery options, retrieve your password, or
    unsubscribe from this list, visit
    https://dev.eclipse.org/__mailman/listinfo/m2e-dev
    <https://dev.eclipse.org/mailman/listinfo/m2e-dev>




_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-dev

Back to the top