[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-dev] War overlays alternative

Hi Fred,

Just added a watch on that issue (174). It is really an irritating bug...

Well, the preferences setting to switch overlay support off in m2e-wtp sounds good for us... less confusing than just implementing overlay support more than one way.

Best regards,

Vazul

2012/2/14 Fred Bricon <fbricon@xxxxxxxxx>
Resources being wiped out on file save is a known issue :Â https://issues.sonatype.org/browse/MECLIPSEWTP-174Â

Hopefully, Rob Stryker (WTP committer) and me should be able to investigate the problem in the next few weeks/months, but can't give an ETA yet. So your alternate solution should definitely be a temporary workaround.

Anyway, I'm -1 on adding a broken alternative to a broken feature.ÂÂWhat we could do however, is add some preferences to disable m2e-wtp's Overlay support. Then you could provide your self hosted, alternative overlay configurator based on linked resources.

That means less maintenance on the m2e-wtp side and gives you plenty of liberty to provide another solution.

WDYT?

Fred Bricon

On Tue, Feb 14, 2012 at 4:33 PM, LÃszlà VÃradi <laszlo.varadi@xxxxxxxxx> wrote:
Hi all,

regarding war overlays, we have some minor problems, which is really related to WTP itself, not m2e-wtp. This is addressed in a server publish configuration, and in a resource change listener to call server's publish on resource change.

But we have faced a much bigger problem, which is also related (I think) to WTP. Somehow, if server is in autopublish mode, some overlaid resources are deleted. Just editing a .js file, saving it, the server publishes it, but suddenly, the whole webapp is broken. Only a clean on the server can resolve the problem, a simple publish won't fix the missing resources.

And as tomcat server adapter cannot handle m2e-wtp consumed references in "serve modules without publishing" configuration (https://issues.sonatype.org/browse/MECLIPSEWTP-164) (as we trying to avoid publishing now), I've just created an alternative way of configuring overlays using linked folders:Âhttps://github.com/vazul/m2eclipse-wtp/commits/overlays_alternative

I'm just wondering, if you review it, it can be part of the main m2e-wtp source. There is a flag in Maven WTP Integration preferences page to switch between the two modes.

It has some drawbacks: cannot handle excludes and includes. War overlay artifacts not present in workspace exploded without web.xml and WEB-INF/lib content, but nothing more (well this can be handled on project level, but we decided to extract war overlay artifacts under the plugin's state location... maybe not a goodÂdecision). Well it fits for us... with lots of overlays.

We are also just testing this configuration, but I'm curious about your opinion.

Best regards,

Vazul


_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-dev




--
"Have you tried turning it off and on again" - The IT Crowd

_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-dev