Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[m2e-dev] m2e-wtp / pomproperties conflict

Hi,

m2e-wtp 0.13.0 adds support for Manifest generation ([1] [2]). In order to trigger the manifest configurator for jar projects, a configurator is mapped to the maven-jar-plugin:jar goal [3].
I only realized yesterday, while trying to release 0.13.0, that it conflicted with the pomproperties configurator which does exactly the same thing [4]
If I Declare the manifest configurator as secondary to the pomproperties one, then it won't be called if pomproperties is not installed.
Which lead me to add a hard dependency from m2e-wtp to pomproperties. Problem is, if you tried to install m2e-wtp from the discovery mechanism, then it would fail without giving an explicit reason to the user, because the pomproperties update site would not be contacted, so the P2 couldn't resolve that dependency.

The decision was taken to remove both the dependency to pomproperties and the pomproperties plugin itself from the marketplace, in order to provide a better user experience.

Adding a dependency to pomproperties was not necessarily a bad decision. I mean any plugin could depend on another one.
IMHO, the marketplace should contact all the update sites available from the connector.xml, and of course, the error message in cause of a dependency issue should be clear.

Anyway, I heartily thank Igor for helping me push m2e-wtp 0.13 out in the open.

Regards,

Fred Bricon

[1] https://issues.sonatype.org/browse/MECLIPSEWTP-45
[2] http://dev.eclipse.org/mhonarc/lists/m2e-dev/msg00496.html
[3] https://github.com/sonatype/m2eclipse-wtp/blob/0.13.0.20110622-1130/org.maven.ide.eclipse.wtp/lifecycle-mapping-metadata.xml#L180
[4] https://github.com/sonatype/m2eclipse-extras/blob/master/org.sonatype.m2e.mavenarchiver.pomproperties/lifecycle-mapping-metadata.xml


--
"Have you tried turning it off and on again" - The IT Crowd

Back to the top