Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [lyo-dev] Problems with OSLC4J 2.2.1
Jad, Andrii and I met yesterday to discuss how to address the issues in 2.2.1.  My meeting notes follow. Since Andrii and I are (soon to be) new committers, I took a lot of notes to make sure we don't miss anything, and to help us through the process.



Meeting conclusions:

1. There are things in the 79 commits between 2.1.0 and 3.0.0-SNAPSHOT that would be beneficial to OSLC4J 2.1.2. Many of these commits are in the codegenerator which is not included in the OSLC4J. However the following would be candidates for inclusion:
    * Resolution to https://bugs.eclipse.org/bugs/show_bug.cgi?id=503995- Jazz auth login does not work with Jazz Authenticator Server and OIDC in CLM 6.x
    * Resolution to https://bugs.eclipse.org/bugs/show_bug.cgi?id=499848- OSLC4J client libraries cannot be built because of outdated dependencies, net.oauth.core:{oauth-consumer, oauth-httplcient} version 20090913 was removed
    * Resolution to Bug 511492 - Add TSLv1.2 support back to the OSLC4J Java client.

2. The maven tests for OSLC4J are limited unit tests, and may not be adequate for testing a significant OSLC4J release. We also need run the testsuite (which is for testing adapter implementations against the OSLC standards)
    * org.eclipse.lyo.client.java  has very limited automated tests. Additional manual testing can be done using the sample code
    * org.eclipse.lyo.core.query has some unit tests, but they don’t appear to be comprehensive
    * org.eclipse.lyo.trs has no unit tests
    * org.eclipse.lyo.oslc4j.core has some tests, but they appear to be tests for specific issues, not a comprehensive test suite
    * org.eclipse.lyo.oslc4j.provider.jena has a lot of tests
    * org.eclipse.lyo.oslc4j.provider.json4j has  some tests
    * org.eclipse.lyo.core.utils  has tests fro reading RDF/XML and Turtle
    * org.eclipse.lyo.oslc4j.wink has no unit tests

3. We agreed to do a service release in a branch off 2.1.0 called 2.1.2 that includes changes for the following issues:
    * https://bugs.eclipse.org/bugs/show_bug.cgi?id=503995
    * https://bugs.eclipse.org/bugs/show_bug.cgi?id=499848
    * Bug 511492

Actions:
1. Andrii will tag 2.1.0 in master and create a 2.1.2 branch

2. Jim will set the lyo version to 2.1.2-SNAPSHOT, and 2.1.2 on release.

3. Andrii will commit changes to this branch for https://bugs.eclipse.org/bugs/show_bug.cgi?id=503995-Jazz auth login does not work with Jazz Authenticator Server and OIDC in CLM 6.x

4. Jim will commit changes for https://bugs.eclipse.org/bugs/show_bug.cgi?id=499848- The client libraries can not be built

5. Jim will commit changes for https://bugs.eclipse.org/bugs/show_bug.cgi?id=511492- Add TSLv1.2 support back to the OSLC4J Java client

6. We will test using the unit tests that are run by Maven for the OSLC4J components using OpenJDK and the IBM SDK

7. We will create a new OSLC4J Service release, version 2.1.2. See https://wiki.eclipse.org/Development_Resources/HOWTO/Release_Reviews#Reviews_are_Not_Required_for_Service_Releases

8. We will deploy OSLC4J v2.1.2 to repo.eclipse.org. See https://wiki.eclipse.org/Services/Nexus#Deploying_artifacts_to_repo.eclipse.org


Future considerations we discussed:
1. Andrii has a branch that includes updates to Jena 3.x. We agreed this would be a good candidate for inclusion in OSLC4J 2.2.0.
2. Jim has a strawman proposal for refactoring eclipse/Lyo to separate concerns, simplify development, and make it easier to use OSLC4J. That will be distributed on lyo-dev
3. We need to consider removing the Wink dependency, perhaps migrating to Jersey/Dropwizard
4. OSLC4J should be published to Maven Central. See https://wiki.eclipse.org/IT_Infrastructure_Doc#Publish_to_Maven_Central


Jim Amsden, Senior Technical Staff Member
OSLC and Linked Lifecycle Data
919-525-6575




From:        Jim Amsden/Raleigh/IBM@IBMUS
To:        "Lyo project developer discussions" <lyo-dev@xxxxxxxxxxx>
Date:        02/01/2017 11:48 AM
Subject:        [lyo-dev] Problems with OSLC4J 2.2.1
Sent by:        lyo-dev-bounces@xxxxxxxxxxx



OSLC4J 2.1.1 was delivered in October 2016 in order to address AT&T’s need to be able to use Jazz Authentication Server to login in a standard way to 6.0.2 CE tools. Unfortunately there are a couple of issues with this release that should be addressed.

First the changes for 2.1.1 were based on 3.0.0-SNAPSHOT, not 2.1.0. This potentially included as many as 80 commits that are not part of 2.1.0, and could therefore introduce bugs unrelated to the authentication changes. Fortunately, of the commits on 3.0.0-SNAPSHOT, there are no commits that impact SDK method signatures. And there appears to be only one commit that changes the behavior of the code: Bug 442517 - Handle incorrectly typed literals. However, we should be consistent about what included in what version and ensure changes are properly tested.

Second, the OSLC4J group/artifact versions in the pom.xml file were not set to 2.1.1 when the build was done, so the distributed file names have the wrong version identifiers:
oslc-java-client-3.0.0-SNAPSHOT.jar
oslc-query-3.0.0-SNAPSHOT.jar
oslc-trs-3.0.0-SNAPSHOT.jar
oslc4j-core-3.0.0-SNAPSHOT.jar
oslc4j-jena-provider-3.0.0-SNAPSHOT.jar
oslc4j-json4j-provider-3.0.0-SNAPSHOT.jar
oslc4j-utils-3.0.0-SNAPSHOT.jar
oslc4j-wink-3.0.0-SNAPSHOT.jar

Possible actions:

1. Do a new OSLC4J release, version 2.1.2, to address the issues above as quickly as possible

2. Determine what branch to use for OSLC4J release version 2.1.2.
   1. Create a branch off 2.1.0 for 2.1.2 and apply the minimal changes from master required to address the requirements for the 2.1.1 release, or
   2. Continue using the current 3.0.0-SNAPSHOT, renaming to 2.1.2-SNAPSHOT and assess the potential impact of commits, and scope of testing needed for the release

3. Update the pom.xml versions to 2.1.2-SNAPSHOT

4. Verify the 2.1.2-SNAPSHOT meets AT&T’s needs

5. Deliver OSLC4J release version 2.1.2

6. Rename the version on HEAD on master from 2.1.2 to 2.2.0-SNAPSHOT

7. Continue development of a proposed 2.2.0 release to include the existing commits on master, merging in any necessary changes from 2.1.2 if needed, plus the work to update dependencies (but not addressing deprecated code).



Jim Amsden, Senior Technical Staff Member
OSLC and Linked Lifecycle Data
919-525-6575
_______________________________________________
lyo-dev mailing list
lyo-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/lyo-dev


Back to the top