Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [lyo-dev] OslcDialog - selection vs creation dialogs
Hello,   Please see my comments inline below.   Please don't hesitate to open Bugzillas for anything you feel is an issue.


On Thu, Apr 11, 2013 at 9:36 AM, Martin P Pain <martinpain@xxxxxxxxxx> wrote:
Hello,

I see from the code for org.eclipse.lyo.oslc4j.core.model.ServiceProviderFactory that the OslcDialog annotations are selection dialogs if on a @GET method and are creation dialogs if on a @POST method.

Firstly, this is not documented on the OslcDialog annotation class. (Apologies that I'm not set up to submit a patch to add such a comment - hopefully someone else can do this quite simply.)

 

Secondly, if you are only implementing the dialogs and not the query capabilities or creation factories then this poses a problem. (As far as I am aware such a situation is allowed by the OSLC specs - creation factories and query capabilities are optional. Such a situation might arise when trying to get an implementation out quickly and the particular clients you are programming for in the first iteration only require the delegated UIs.)

I expect that for selection dialogs this is not a problem as it looks like you could put the annotation on the method that returns the dialog itself. However, for creation dialogs that method will also be a @GET method - which would result in the dialog being exposed as a selection dialog. I guess the workaround would be to put the annotation on the @POST method used for prefilling creation dialogs - but this also is optional.


I opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=405502 to track this.   As a workaround you could annotate dummy GET or POST methods, but that is pretty hacky.  An optional additional dialog type parameter in the annotation is a good idea.
 
Is there another way to say whether an @OslcDialog is creation or selection? If not, could I suggest there be such a means (such as another parameter/field in the annotation)?

Regards,
Martin Pain

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

_______________________________________________
lyo-dev mailing list
lyo-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/lyo-dev


Back to the top