Re: [linuxtools-dev] Gerrit: Error on FunkyTraceTest

[Xavier Raynaud <xavier.raynaud@xxxxxxxxx>]

Hi Alexandre,

Ok, many thanks.
It's fixed now: (https://git.eclipse.org/r/#/c/22442/)

X

On 02/28/2014 09:01 PM, Alexandre Montplaisir wrote:
> Hi Xavier,
>
> I think it was due to using "assumeTrue()" in a JUnit @BeforeClass
> method. If the check fails, Eclipse will skip the whole class as one
> would expect, but it seems Maven doesn't handle it the same way, and
> fails instead.
>
> Normally that trace was available, so the check was passing. Maybe for
> some reason the web server was not available this morning, but then it
> should skip the test, and not fail it.
>
> I'll look into everywhere we use assumeTrue(), and make sure we do not
> do it in BeforeClass methods. It should be done in @Before (or in
> individual @Test methods) to be skipped correctly.
>
>
> Cheers,
> Alex
>
>
> On 14-02-28 07:52 AM, Xavier Raynaud wrote:
> > Hi,
> >
> > I've push some patches on gerrit, and obtained some unexpected errors
> > on absolutely something else:
> >
> > Tests in error:
> >    org.eclipse.linuxtools.tmf.core.tests.ctfadaptor.FunkyTraceTest:
> > got: <false>, expected: is <true>
> >    org.eclipse.linuxtools.tmf.core.tests.ctfadaptor.FunkyTraceTest
> >
> > I know that Bernd had the same issue.
> >
> > Does somebody knows what's this issue, and how to fix it?
> >
> > Thanks,
> >
> > Xavier