Re: [linuxtools-dev] Change ValgrindCoreParser to support different valg

[David Meng <dmeng@xxxxxxxxxxxxxx>]

This is the method we are intended to introduce:
 
protected String[] parseFilename(String line) {
    Return ValgrindParserUtils.parseFilename();
}

But you need to make the ValgrindCoreParser class public. 

I will open a bug first.

David

-----Original Message-----
From: linuxtools-dev-bounces@xxxxxxxxxxx [mailto:linuxtools-dev-bounces@xxxxxxxxxxx] On Behalf Of Aleksandar Kurtakov
Sent: Thursday, December 05, 2013 1:05 PM
To: Linux Tools developer discussions
Subject: Re: [linuxtools-dev] Change ValgrindCoreParser to support different valgrind output format

----- Original Message -----
> From: "David Meng" <dmeng@xxxxxxxxxxxxxx>
> To: linuxtools-dev@xxxxxxxxxxx
> Sent: Thursday, December 5, 2013 7:32:08 PM
> Subject: [linuxtools-dev] Change ValgrindCoreParser to support 
> different valgrind output format
> 
> 
> 
> Hello,
> 
> 
> 
> We have our own version of valgrind executable running on a remote 
> target, however the output format is a little different from the 
> standard format, which cause trouble parsing the filename and line 
> number using ValgrindCoreParser.

In general, adding support for custom(not-upstream) formats is not of interest, but if one is willing to help us making better tool we are more than interested to work together.

> 
> 
> 
> There are two possible solutions:
> 
> 1) Move ValgrindCoreParser to a public package and introduce a new 
> ‘parseFilename’ method

What semantics would you put in such a method? Do you mean parse(fileName) or parseFilename as a workaround to plugin currently retrieving pid from filename and if you use different naming scheme it will fail for you.

> 
> 2) Modify the ValgrindCoreParse to support different formats
> 
This might be a better option if done carefully to really define and document good API for valgrind plugin.
> 
> 
> Could you please advise what the best solution would be for this case?

Start with opening a bug about that.

Alexander Kurtakov
Red Hat Eclipse team

> 
> 
> 
> Thank you!
> 
> 
> 
> David
> 
> 
> ---------------------------------------------------------------------
> This transmission (including any attachments) may contain confidential 
> information, privileged material (including material protected by the 
> solicitor-client or other applicable privileges), or constitute 
> non-public information. Any use of this information by anyone other 
> than the intended recipient is prohibited. If you have received this 
> transmission in error, please immediately reply to the sender and 
> delete this information from your system. Use, dissemination, 
> distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
> 
> _______________________________________________
> linuxtools-dev mailing list
> linuxtools-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
> 
_______________________________________________
linuxtools-dev mailing list
linuxtools-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev
---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.