Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [linuxtools-dev] Gerrit reviews,


Please try to not submit for review patch series - gerrit doesn't handle them gracefully and it makes it really hard to review stuff.

The problem is Gerrit makes it more difficult for the submitter to separate the patches than for the reviewer to review them in a series; for a bunch of patches to be submitted independently each one has to be done in an independent branch.

For the reviewer the patch is marked with a "depends on" and a link to the parent patch. If needed the reviewer can review only the oldest patch until it is approved and committed then do the next. Or mark a patch as approved but not merge it and the submitter can go through an submit the patches after the series is approved.

At least please don't make it for patches that can be easily separated like the recent systemtap series.


That is true. For completely independent patches a branch should be created for each one.

  Sami


Back to the top