Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [linuxtools-dev] Valgrind versions - support only newest?

On 07/03/2012 05:36 PM, Elliott Baron wrote:
Hi Daniel,

What I have done for new options that are incompatible with old versions is to do a version check in every place this option is used. These are likely only in the launch configuration tab and the launch delegate, see [1] and [2] for examples. This allows users of the new Valgrind version to take advantage of these options, while hiding them from incompatible older versions.

Have you considered case where project is remote? I mean, in this case you should verify valgrind version in the remote location.

Actually, it is something we need to be carefully since that most of Linux Tools plug-ins now supports remote execution.


Thanks,
Elliott

[1] http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/tree/valgrind/org.eclipse.linuxtools.valgrind.memcheck/src/org/eclipse/linuxtools/internal/valgrind/memcheck/MemcheckToolPage.java#n134 [2] http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/tree/valgrind/org.eclipse.linuxtools.valgrind.memcheck/src/org/eclipse/linuxtools/internal/valgrind/memcheck/MemcheckLaunchDelegate.java#n52

On 07/03/2012 03:58 PM, Daniel HB wrote:
Hello,

While doing some tests with Helgrind I saw that the newest Helgrind
version comes with more options than the current Helgrind plug-in
supports today. I haven't noticed it before because the older options
still exists and running Helgrind does not trigger any errors. I need to
check, but it's possible that the other Valgrind plug-ins are outdated
as well.

It's a no-brainer that we should support the newest Valgrind version
always (right?) but are we going to keep a backwards compatibility with
the older versions?

Of course that it doesn't matter the answer, this won't be a work for
1.1. But we can probably consider it for the next minor version. It's
not a bug fix so we don't need to rush.


Thanks,




_______________________________________________
linuxtools-dev mailing list
linuxtools-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/linuxtools-dev




Back to the top