Re: [jgit-dev] JGit patches

[Matthias Sohn <matthias.sohn@xxxxxxxxx>]

moving this conversation to the list

On Jan 8, 2018 3:27 PM, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:

Hi Martin,

I watched the recording of your presentation on gerrit multi-master at the last Gerrit user conference in London

https://gerrit.googlesource.com/homepage/+/md-pages/docs/MultiMaster.md

First of all thanks for this nice talk.

You mentioned that you are using an old JGit version and have a couple of JGit patches you have done in your fork which you didn't yet contribute upstream. I'd be interested to get them so everyone can benefit. Could you please push them ? If it helps push them to the corresponding stable branch at Eclipse which matches your base version then we could help porting them to master.

thanks

-Matthias

On Tue, Jan 9, 2018 at 2:47 AM, Martin Fick <mfick@xxxxxxxxxxxxxx> wrote:

I will take a look to see what I can find, I know this one, a bug fix https://git.eclipse.org/r/#/c/17088/1 and its child, a performance fix are valuable to us.

I restored these 2 patches and rebased them on master.

The first change https://git.eclipse.org/r/#/c/17088/  seems to break some newer tests, 

Interestingly with the second patch those test failures don't happen. Looks like it fixes the issues the first one created.

 

Something that we don't have yet on jgit, but we do in our git ref-packing, is too preserve the old packed-refs files for a full repacking cycle, it prevents data loss on NFS by avoiding stale file handles.  It is a similar idea to this change https://git.eclipse.org/r/#/c/87969/ but for the packed-refs file instead of the object files.

So during gc you want to first delete old packed-refs from last repack in preserved/ directory,

then repack refs into a new packed-refs file and move the old packed-refs file to the preserved/ directory ?

And this would ensure that another node not doing repack could concurrently still read from the preserved/packed-refs file.

Did I get this right ?

-Matthias