| Re: [jgit-dev] Change in jgit[master]: Provide native lstat() via JNI |
On 27.11.10 02:37, "Shawn Pearce (Code Review)" <codereview-daemon@xxxxxxxxxxx> wrote:
> Shawn Pearce has posted comments on this change.
>
> Change subject: Provide native lstat() via JNI
> ......................................................................
>
> Patch Set 8: I would prefer that you didn't submit this
>
> I think this is ready to submit. But we shouldn't store binary object files:
>
> $ file org.eclipse.jgit.macosx_x86_64/native/libjgitnative.jnilib
> org.eclipse.jgit.macosx_x86_64/native/libjgitnative.jnilib: Mach-O 64-bit
> dynamically linked shared library x86_64
>
> The build should be integrated into the master Maven build, and we should also
> support Linux x86 and x86_64 builds, but we can >address those with follow-up commits.
>
> --
> To view, visit http://egit.eclipse.org/r/1815
I fully agree, we should not store binaries and we should integrate the make
into the central Maven build.
Unfortunately I have zero experience how to setup a C make using
Maven so that this also works on hudson.eclipse.org.
Does anyone have experience with that and can give me some hints ?
Do we run the native builds on different platforms there or do we
better go for cross-compilation ?
--
Matthias