Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] Fwd: [Bug 324868] New: git clone fails for org.eclipse.mdt

On Sun, Sep 12, 2010 at 4:11 PM, Matthias Sohn
<matthias.sohn@xxxxxxxxxxxxxx> wrote:
> 2010/9/10 Chris Aniszczyk <caniszczyk@xxxxxxxxx>
>>
>> Short skip of block
>
> I can reproduce the problem, the failure occurs in IO.skipFully(); according
> to its javadoc this exception is thrown
> under the following condition:
>
> * @throws EOFException
> *             the stream ended before the requested number of bytes were
> *             skipped
> but I have not yet any clue how this can happen, with native git I am able
> to clone this repository and fsck --full
> on the clone doesn't return any problems.

Can you reproduce this when commit
741659fed4e73b71693b408e137804b17e65f0cb is included?

I wonder if the problem with skipping in the base is because we are
skipping the wrong length because a prior read didn't correctly update
the base stream's pointer.  Which would lead us to try and skip the
base by too large of an amount, exceeding the length of the base.
That would trigger the skipFully to fail, because it tried to skip
some number of bytes more than were left in the stream.  741659fe is
supposed to fix that.  But maybe we missed something still.

-- 
Shawn.


Back to the top