Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] canCommit for RepositoryState REBASING_REBASING etc.

"Lay, Stefan" <stefan.lay@xxxxxxx> wrote:
> Currently the RepositoryState's canCommit() method returns true for the states REBASING_REBASING, REBASING, REBASING_MERGE, REBASING_INTERACTIVE.
> 
> This has the effect in EGit that the commit dialog opens and a commit can be done with some strange results (https://bugs.eclipse.org/bugs/show_bug.cgi?id=322541).
> 
> I would expect that canCommit() returns false for these states.

Nope, its correct.  You can make (or amend) a commit during rebase.

-- 
Shawn.


Back to the top