Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] JGit's license starts in the middle of the sentence - should this be fixed?

2010/7/2 Mykola Nikishov <mn@xxxxxxxxx>
Hi,

When upgrading [1] NBGit from an age-old version of JGit to a latest
released version I've replaced the previous license with the license for
0.8.4 version [2] and noticed that the first paragraph of the current
JGit's license starts in the middle of the sentence:

--8<---------------cut here---------------start------------->8---
a42177a Upgrade dependencies to JGit 0.8.4
diff --git a/release/modules/ext/org-spearce-jgit.LICENSE.txt b/release/modules/ext/org.eclipse.jgit.LICENSE.txt
similarity index 79%
rename from release/modules/ext/org-spearce-jgit.LICENSE.txt
rename to release/modules/ext/org.eclipse.jgit.LICENSE.txt
index 2917c22..a628e2e 100644
--- a/release/modules/ext/org-spearce-jgit.LICENSE.txt
+++ b/release/modules/ext/org.eclipse.jgit.LICENSE.txt
@@ -1,4 +1,11 @@
 /*
+ * and other copyright owners as documented in the project's IP log.
+ *
+ * This program and the accompanying materials are made available
+ * under the terms of the Eclipse Distribution License v1.0 which
+ * accompanies this distribution, is reproduced below, and is
+ * available at http://www.eclipse.org/org/documents/edl-v10.php
+ *
 * All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or
@@ -13,7 +20,7 @@
 *   disclaimer in the documentation and/or other materials provided
 *   with the distribution.
 *
- * - Neither the name of the Git Development Community nor the
+ * - Neither the name of the Eclipse Foundation, Inc. nor the
 *   names of its contributors may be used to endorse or promote
 *   products derived from this software without specific prior
 *   written permission.
@@ -32,3 +39,4 @@
 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
+
--8<---------------cut here---------------end--------------->8---

So NBGit in the credits section points to the html version of the
license [4] but still includes the original text [3] with a broken first
paragraph.

I'm not sure if this is an issue that must be fixed, but anyway...

[1] http://github.com/manandbytes/nbgit/commits/move-to-org.eclipse.jgit-0.8.4
[2] http://egit.eclipse.org/w/?p=jgit.git;a=blob_plain;f=LICENSE;hb=5ed96eb7f44edb06ebf17eece0f9679ee5713446
[3] http://github.com/manandbytes/nbgit/commit/a42177a5987ff9f0a0e87a061c6c15aaf4daa26c#diff-7
[4] http://www.eclipse.org/org/documents/edl-v10.html

This is the exact text agreed with the Eclipse foundation to be used as license header in all jgit sources.
It is to be prepended by the explicit copyright statement of the respective author.

Maybe we should rename this to LICENSE-HEADER and have the plain license text as LICENSE.

--
Matthias

Back to the top