Re: [jetty-users] Possible bug with WebSocket in BatchMode.ON and flush

[Jesse McConnell <jesse.mcconnell@xxxxxxxxx>]

can you open an issue for this here: https://github.com/eclipse/jetty.project/issues

--
jesse mcconnell
jesse.mcconnell@xxxxxxxxx

On Tue, Jul 11, 2017 at 12:23 AM, Erel Uziel <ereluziel@xxxxxxxxx> wrote:

Hi,

We have upgraded from Jetty 9.3 to 9.4.6 and started seeing NPE errors in CompressExtensions.

 

After some digging I believe that it is related to a change in CompressExtensions.deflate.

It tries to compress the FLUSH_FRAME and throws a NPE as it has no payload. Adding payload to FLUSH_FRAME doesn't help as it will prevent FrameFlusher from behaving correctly.

 

The suggested solution is to change CompressExtensions.deflate to:

private void deflate(FrameEntry entry)

{

Frame

frame = entry.frame;

BatchMode

batchMode = entry.batchMode;

if (OpCode.isControlFrame(frame.getOpCode()) || frame == FrameFlusher.FLUSH_FRAME)

{

// Do not deflate control frames

nextOutgoingFrame(

frame,this,batchMode);

return;

}

compress(

entry,true);

}

 

Thank you.

Best regards,
Erel Uziel
Anywhere Software

_______________________________________________
jetty-users mailing list
jetty-users@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jetty-users