Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jetty-users] Dependency tree built

BTW: Something wanna make sure with you Simone.

I saw you just create another construct method for HeadersFrame with the default streamid 0;

But here I am not so clear what do you mean

>We were sending the streamId as the parentStreamId
>and viceversa.


If you are available, could you please give me a short example. For example, I have  requests A ,B & C. I hope the dependency tree can be this:

       A
     /     \
   B      C 

And then their HeadersFrame is

HeadersFrame A = new HeadersFrame(?,?,new PriorityFrame(?,?,?,?),?)
HeadersFrame B = new HeadersFrame(?,?,new PriorityFrame(?,?,?,?),?)
HeadersFrame C = new HeadersFrame(?,?,new PriorityFrame(?,?,?,?),?)

Thank you very much.

Best Regards
Muhui Jiang

2015-09-14 20:50 GMT+08:00 Muhui Jiang <jiangmuhui@xxxxxxxxx>:
Thanks Simone.

I am going to have a try on it. I will tell you the result later.

Best Regards
Muhui Jiang

2015-09-14 17:55 GMT+08:00 Simone Bordet <sbordet@xxxxxxxxxxx>:
Hi,

On Sun, Sep 13, 2015 at 11:25 AM, Simone Bordet <sbordet@xxxxxxxxxxx> wrote:
> Hi,
>
> On Sun, Sep 13, 2015 at 9:46 AM, Muhui Jiang <jiangmuhui@xxxxxxxxx> wrote:
>> Hi all:
>>
>> According to the Jetty javadoc. The construct method of HeadersFrame is:
>>
>> HeadersFrame(int streamId, MetaData metaData, PriorityFrame priority,
>> boolean endStream).
>>
>> And the construct method of PriorityFrame is
>>
>> PriorityFrame(int streamId, int dependentStreamId, int weight, boolean
>> exclusive).
>>
>> They all have a streamid. What is the difference? If I want to build a
>> dependent tree which streamid should be dependent? Many Thanks.
>
> The variable names explain it all.

Okay, my mistake. We were sending the streamId as the parentStreamId
and viceversa.
That was probably the reason H2O did not apply any priority logic,
since the stream ids were sent wrong.

> For reference, see also:
> http://tools.ietf.org/html/rfc7540#section-5.3 and
> http://tools.ietf.org/html/rfc7540#section-6.3.
>
> HTTP2Client does not have yet the capability to send a single PRIORITY
> frame, but I tracked this issue with:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=477270.

This is also fixed.

Can you please try and build the "master" branch, and try again to see
if H2O now applies the priority logic ?

Thanks !

--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-users mailing list
jetty-users@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jetty-users



Back to the top