Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[jetty-users] JDBCSessionManager dirty operations

Hi,

Current org.eclipse.jetty.server.session.JDBCSessionManager has removeAttribute as this:

  public void removeAttribute (String name)
{
super.removeAttribute(name);
_dirty=true;
}

This has a side effect because of making dirty for every removing operation. This is causing a lot of trouble because each jstl set ( c:set ) call in JSP pages is also calling removeAttribute internally. What I am suggesting is that something like this:


@Override
public void removeAttribute(String name) {
synchronized (this){
Object attribute = getAttribute(name);
if(attribute != null){
super.removeAttribute(name);
_dirty = true;
}
}
}

public

https://gist.github.com/cemo/9236abe34d2b126242ad

What do you think? 

Back to the top