Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jetty-users] Upgrading to Jetty 9.1

Good find and a _critical_ bug in my view.

A change that came with 9.0 as it was this in 8.x :-

                     _header.put(CONNECTION_KEEP_ALIVE);
                     if (connection!=null)
                     {
                         _header.setPutIndex(_header.putIndex()-2);
                         _header.put((byte)',');
                         _header.put(connection.toString().getBytes());
                         _header.put(CRLF);
                     }

which had less logic, shorter lines... Yes, it copied 2 more bytes than it needed to but I would prefer less logic/shorter code over saving 2 bytes.

To fix this, you could _try_ turning off one connect on the f5 if you don't need it for other reasons.

We are also behind an F5, and are just about to start looking at moving from 8.x to 9.x.   ... so thanks ... will raise on support.


On 25 January 2014 04:08, Stefan Magnus Landrø <stefan.landro@xxxxxxxxx> wrote:
Just came across this code in HttpGenerator.java - the 

header.put(CONNECTION_KEEP_ALIVE,0,CONNECTION_CLOSE.length-2); 

looks very much like a bug to me:

           else if (keep_alive)
            {
                if (connection==null)
                    header.put(CONNECTION_KEEP_ALIVE);
                else
                {
                    header.put(CONNECTION_KEEP_ALIVE,0,CONNECTION_CLOSE.length-2);
                    header.put((byte)',');
                    header.put(StringUtil.getBytes(connection.toString()));
                    header.put(CRLF);
                }
            }


2014/1/24 Stefan Magnus Landrø <stefan.landro@xxxxxxxxx>
Hi there,

We're in the process of upgrading to jetty 9.1 from latest jetty 8.

Our app servers sit behind a F5 Big Ip load balancer, and after upgrading to 9.1, requests to resources that produce responses with Transfer-Encding: chunked, the request from the client (e.g. curl) hang for like 30 seconds due to what seems to be our connection keep-alive timeout.

What could be causing this issue? 

Any pointers would be appreciated,

Cheers,

Stefan



--
BEKK Open
http://open.bekk.no

TesTcl - a unit test framework for iRules

_______________________________________________
jetty-users mailing list
jetty-users@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/jetty-users



Back to the top