Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jetty-dev] Jetty CDI/Weld integration and Arquillian container

Hi Jan,

Dne 18.6.2015 v 04:50 Jan Bartel napsal(a):
Hi Martin,

On 5 June 2015 at 16:43, Martin Kouba <mkouba@xxxxxxxxxx> wrote:
Hello Jetty devs,

recently we came accross a problem while deploying a webapp with bundled
Weld Servlet to a Jetty standalone instance [1]. The investigation resulted
in a new FAQ entry in Weld [2] and also a Jetty bug [3].

Thanks for updating the weld faq. Indeed for jetty < 9.3 you'll need
to put in special config to expose the ServletHandler.Decorator class.
When you get around to it, could you update the weld docs in chapter
18 and mention that for jetty-9.3 you can use the jetty cdi module and
don't need the server/system classes setup?

The docs is already updated (although not published for the lastest stable version) We've also found that excluding ServletContextHandler$Decorator is not enough - see also http://docs.jboss.org/weld/reference/latest-master/en-US/html/environments.html#_jetty).


As the regards the jetty bug[3], I'm currently looking into that.
However, the good news is that for jetty-9.3 setting the server/system
classes is no longer necessary to expose ServletHandler.Decorator.
I've just checked in the org.eclipse.jetty.webapp.WebAppContext class
and removed those unneeded lines. So, if you're using 9.3 then the bug
won't affect you.

It is necessary if you don't use the cdi module for any reason ;-)


  The CDI/Weld module
which is part of the Jetty dist since 9.2.4 looks good except the Jetty docs
mention a wrong module name - "weld" instead of "cdi" [4].

Thanks for pointing that out, I've updated the doco to correct that,
and to correct the instructions on what lines are required in the
web.xml to enable weld for a webapp. The doco should get published by
our ci system shortly.

I think we still would have some work to do to make weld easily usable
with the jetty-maven-plugin ... something to look into in the future
:)


Nevertheless, it would be great to finish the Arquillian Jetty container
cleanup started by Joakim Erdfelt. Is there any open issue or should we
initiate a new release (1.0.0.CR2 was released on 22 Jul 2013)?

I'll let Joakim comment on this one.

The other
question is whether it would be possible to implement a managed Jetty
container so that we could detect similar issues in our test suite. Weld
team is ready to help. We don't have a deep knowledge of Jetty though ;-)

The jetty team is ready to help but we don't have a deep knowledge of
weld :) If you can explain a little more about what you want to
achieve we can help you get there.

This is not about weld but about arquillian. Joakim is probably the best person to ask as he did a lot of work on jetty arquillian containers.


thanks for following up!

Thanks for all your responses!


Jan



Thanks,

Martin (on behalf of Weld team)


[1]
https://issues.jboss.org/browse/WELD-1959

[2]
http://weld.cdi-spec.org/documentation/#11

[3]
https://bugs.eclipse.org/bugs/show_bug.cgi?id=469384

[4]
http://www.eclipse.org/jetty/documentation/current/framework-weld.html

--
Martin Kouba
Software Engineer
Red Hat, Czech Republic
_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/jetty-dev




--
Martin Kouba
Software Engineer
Red Hat, Czech Republic


Back to the top