Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jetty-dev] Merging small fix for HTTP 1.1 parsing error?
Joakim, thank you for taking a look at the bug. 

Can you elaborate on how it was invalid?

The bug happens when you use HttpTester.parseRequest to parse the response.  The test you have added uses 

HttpParser.RequestHandler handler  = new Handler();
HttpParser parser= new HttpParser(r);
parser.parseNext(buffer);

which uses the HttpParserTest.Handler as the RequestHandler passed to the HttpParser.   This test case works, with \n or \r\n ending the lines

HttpTester.parseRequest method uses

Request r=new Request();
HttpParser parser =new HttpParser(r);
parser.parseNext(request);

which fails because HttpTester.Request is used as the RequestHandler. 

On Sat, Oct 11, 2014 at 10:56 PM, Joakim Erdfelt <joakim@xxxxxxxxxxx> wrote:
Test case was invalid, it wasn't testing what you thought it was.

Committed fixed testcase, no RuntimeError present with correct tests.
This is on branch jetty-9.2.x (aka jetty 9.2.4-SNAPSHOT)

Closing bug as invalid.

--
Joakim Erdfelt <joakim@xxxxxxxxxxx>
Expert advice, services and support from from the Jetty & CometD experts

On Sat, Oct 11, 2014 at 8:35 PM, Chris Heisterkamp <cheister@xxxxxxxxxxxx> wrote:
I'm wondering if someone can tell me how I could get a patch to the HttpTester merged?   There is a small bug in the HttpTester when it parses an HTTP/1.1 message that has a straightforward test case and small fix.   Bug 440823 https://bugs.eclipse.org/bugs/show_bug.cgi?id=440823

It has been sitting without activity for two months and is keeping use from updating past Jetty 9.1.4.  Does it need to be updated with more information or is this just the typical response time for patches?

Thanks,
    Chris

_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jetty-dev


_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jetty-dev

Back to the top