Re: [jetty-dev] Need help/answers on issue in Orbit's version of org.apa

[Jan Bartel <janb@xxxxxxxxxxx>]

Hi David,

On 16 September 2014 16:44, David M Williams <david_williams@xxxxxxxxxx> wrote:
> Jetty Developers,
>
> Correct me if I'm wrong, but believe that org.apache.jasper.glassfish
> (version 2.1.0 and version 2.2.2) were contributed "for" Jetty, by Hugues
> Malphettes.

Sounds about right.


>
> Is Hugues still "around"? Whether he is or not, we'd appreciate someone
> helping to untangle problems caused by org.apache.jasper.glassfish versoin
> 2.2.2.

I don't think Hugues is "around" much anymore.

>
> See bug 442310 [1].
>
> It appears it is used by an number of Eclipse projects, and people in the
> community, but Jetty itself does not use it. [2]  Though an earlier
> (cleaner) version of it appears in your "release 8.x" stream.

For jetty-8, and maybe some of  the 9.0 releases we used this artifact:

       <groupId>org.eclipse.jetty.orbit</groupId>
       <artifactId>org.apache.jasper.glassfish</artifactId>
       <version>2.2.2.v201112011158</version>

AFAICR this was code that we took from the src and binary that Hugues
submitted for IP clearance and put it into the maven repository in a
local where Jetty could consume it easily. So I don't think (but I
could be wrong) that we ever consumed it directly from Orbit like we
did earlier versions of the jasper artifact.

Jesse did the extraction into the maven repo, so he can probably give
some more info here.

As I recall, the glassfish guys do NOT bundle the
org.apache.jasper.compiler.JDTJavaCompiler class and we were having to
patch it in, along with a couple of other patches to prevent jasper
from trying to use the in-jvm compiler by default (which doesn't work
in osgi land).  In later versions of glassfish - and I'm not sure
exactly which ones - the patches were no longer necessary but it WAS
still necessary to add in the JDTJavaCompiler class.

> The problems are, roughly, it is quite a bit different that version 2.1.0,
> in unexpected ways, and, frankly, appears only "half done" or perhaps done
> for some special purpose, that Jetty itself did not use it for.
> Specifically, it embeds a version of JDT compiler, making it impossible for
> people to use with Java 8, (i.e. change the compiler), plus it exports
> "org.apache.jasper" as "2.2.2", instead of "6.0" (or "7"?).

Sounds like a mistake. The jdt classes shouldn't be inside that bundle.

> So, I myself am tempted just to yank it out of active builds, saying its an
> invalid bundle, and tell people they are stuck with the old one, or
> transition to a solution that uses a "pure" org.apache.jasper bundle, plus
> JDT compiler of their choice (how ever that is done?)  but before taking
> such drastic action,  ... wanted to first reach out to you Jetty developers
> to see if you could help ... either fix the bundle in a way that would not
> break current adopters, or ... maybe better, educate us on "the right" way
> to solve the fundamental problem (of getting JSP support with Java 8). I'm
> assuming you have "a whole new solution" in your 9.x stream ... but on the
> surface, I am not sure if it uses "standard" packages from other projects,
> or if you have customized those other packages in ways that you needed to
> for Jetty's purposes?

Well for starters we gave up on glassfish jsp and went (back) to
Apache jsp, version 8.0.9. We're re-packaging their binary jars
ourselves to 1) exclude a tomcat-specificish
ServletContainerInitializer that we need to replace for use with jetty
and 2) produce better osgi manifest and 3) reduce the number of jsp
related jars. We consume these repacked jars from maven central:

http://repo1.maven.org/maven2/org/mortbay/jasper/apache-jsp/8.0.9.M3/


> Please comment in the bug if you can help ... or ... please let us know
> explicitly if you can not.

Let us know if we can give you any more info.


>
> Thanks,
>
> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=442310
> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=442310#c15
>
>
>
>
> _______________________________________________
> jetty-dev mailing list
> jetty-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/jetty-dev



-- 
Jan Bartel <janb@xxxxxxxxxxx>
www.webtide.com
'Expert Jetty/CometD developer,production,operations advice'