Re: [jetty-dev] http2/https/spdy modules

[Greg Wilkins <gregw@xxxxxxxxxxx>]

Simone,

I don't think that is an improvement as you have hard coded properties that require editing.

The way that I had it setup you did not need to edit any ini file to set properties.

If you just enabled http2, then you would get an SSL ServerConnector with just http2 - no http/1.1 as the default protocol.  With your setup, you need to edit the ini file to reset the default protocol.

The properties are just not needed as the default protocol and supported protocols can be worked out by the factories added.

As it was you could do any of the following:

 java -jar start.jar --add-to-startd=https,http2,spdy

 java -jar start.jar --add-to-startd=https,http2

 java -jar start.jar --add-to-startd=https,spdy

 java -jar start.jar --add-to-startd=https

 java -jar start.jar --add-to-startd=http2,spdy

 java -jar start.jar --add-to-startd=http2

 java -jar start.jar --add-to-startd=spdy

and which ever one you picked just worked without any editing.

More over you could disable any protocol simply with one of:

 rm start.d/http2.ini

 rm start.d/https.ini

 rm start.d/spdy.ini

and it just worked without editing.

Ping me on IRC when you are next online and we can go over how it was working and you can explain what problem you were trying to fix.

cheers

On 12 August 2014 07:57, Simone Bordet <sbordet@xxxxxxxxxxx> wrote:

Hi,

On Thu, Aug 7, 2014 at 6:57 AM, Greg Wilkins <gregw@xxxxxxxxxxx> wrote:
>
> Note all,
>
> I've reworked the modules for ssl, https, spdy and http2 in the jetty-http2
> branch.
>
> Now the ssl module creates the ServerConnector and SslContextFactory.
>
> Each of the https,spdy and http2 modules just adds the appropriate
> connection factory to the common ServerConnector, rather than create it's
> own that competes for the same port.
>
> The port is now set with the ssl.port property rather than individual
> protocol port settings.
>
> The result is that the ssl ServerConnector can now serve any combination of
> https, http2, spdy/2 and spdy/3

I have improved over this, and made configurable via properties the
protocols advertised by ALPN/NPN.

So now protonego-[alpn|npn].xml specify 2 properties:

protonego.protocols
protonego.defaultProtocol

In http2.mod these properties are value to:

protonego.protocols=h2-14,http/1.1
protonego.defaultProtocol=http/1.1

while in spdy.mod these properties are value to:

protonego.protocols=spdy/3,http/1.1
protonego.defaultProtocol=http/1.1

In this way, there is no need to copy to a jetty.base
etc/protonego-[alpn|npn].xml to specify the protocols to use, but we
just specify the new properties in start.ini.

However, there is still a small glitch: for websites that expose both
http2 and spdy, those properties are generated twice in start.ini.
I like this better than having to copy etc/protonego-[alpn|npn].xml to
jetty.base.
Can this glitch be worked around ?

--
Simone Bordet
----
http://cometd.org
http://webtide.com
http://intalio.com
Developer advice, training, services and support
from the Jetty & CometD experts.
Intalio, the modern way to build business applications.
_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jetty-dev