Re: [jetty-dev] Contributing a patch with cleaned up code

[Alexander Orlov <alexander.orlov@xxxxxxxxx>]

Ok, I just filed an issue.

Alex

On Mar 3, 2014, at 17:16 , Joakim Erdfelt <joakim@xxxxxxxxxxx> wrote:

Code submissions, even in patch form, have to go through legal vetting (hey, we're an Eclipse project after all).

The best way is to start, is to file a bug (under RT/Jetty) and attach the proposed patch.

https://bugs.eclipse.org/

--

Joakim Erdfelt <joakim@xxxxxxxxxxx>

webtide.com - intalio.com/jetty

Expert advice, services and support from from the Jetty & CometD experts

eclipse.org/jetty - cometd.org

On Sat, Mar 1, 2014 at 8:39 PM, Alexander Orlov <alexander.orlov@xxxxxxxxx> wrote:

Hi,

I've already signed the CLA and would like to contribute the attached patch.

Summary of changes to the jetty-runner module:

* removed <groupId>org.eclipse.jetty</groupId> from pom.xml as it's inherited from the parent pom

* removed MalformedURLException as IOException will always be thrown instead, as it's a super class of MalformedURLException

* replaced a huge if-else block by an easier comprehendible switch block

* removed redundant semicolons

* replaced some old-school for loops by for-each loops 

* replaced Java7-redundant Generic declarations

I'd like to commit this patch as

"Cleanup code and improve readability"

Do I have to fil an issue or what is the procedure of contributing these kind of patches?

Cheers,

Alex

._.

_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/jetty-dev

._._______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/jetty-dev

._.