Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jetty-dev] Pull requests ?

Greg;

I actually tried the patch you made, because intuitively it's the
correct way to fix it : ) But I got it wrong because I am unfamiliar
with this asynch stuff that the cool kids use:) Looking at the code
now it looks all so simple....

I tested the change and obviously it works. I closed the pull request :)

We had the definite OK from legal@apache on pull requests a little
while ago, hope eclipse gets the same - it sure makes things easier
for everyone :)

Kristian



2013/8/9 Greg Wilkins <gregw@xxxxxxxxxxx>:
> Pushed by changed through
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=414727
>
>
>
>
> On 9 August 2013 14:12, Greg Wilkins <gregw@xxxxxxxxxxx> wrote:
>>
>>
>> Hmmm I've just looked at them and I can see a problem in that the send
>> method is async, so you can't close the resource in a try block as the
>> callback may come much later.
>>
>> So I'm passing a Closeable to the callback and it will close it when the
>> send completes or fails.
>>
>> cheers
>>
>>
>>
>> On 9 August 2013 13:59, Greg Wilkins <gregw@xxxxxxxxxxx> wrote:
>>>
>>> Kristian,
>>>
>>> the other thing you can do is open a bugzilla with a diff created from
>>> git attached and we'll apply that - that should get your author name into
>>> the commit comment and also gives you a chance to e-sign a CLA.
>>>
>>> Failing that, I can just add your cleanup manually (but then you don't
>>> get credit other than here - THANKS)
>>>
>>> cheers
>>>
>>>
>>>
>>>
>>> On 7 August 2013 16:40, Kristian Rosenvold <kristian.rosenvold@xxxxxxxxx>
>>> wrote:
>>>>
>>>> I sent a pull request on github
>>>> (https://github.com/eclipse/jetty.project/pulls), do I need to do
>>>> anything else ? Are you guys set up for pull requests ?
>>>>
>>>> Kristian
>>>> _______________________________________________
>>>> jetty-dev mailing list
>>>> jetty-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/jetty-dev
>>>
>>>
>>
>
>
> _______________________________________________
> jetty-dev mailing list
> jetty-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/jetty-dev
>


Back to the top