Re: [jetty-dev] rfc6455 question (websockets)

[Joakim Erdfelt <joakim@xxxxxxxxxxx>]

Interesting.

Not sure Error 426 would be well supported on browsers.

But the missing Sec-WebSocket-Version on the response for error 400 is definate bug.

--

Joakim Erdfelt <joakim@xxxxxxxxxxx>

webtide.com

Developer advice, services and support
from the Jetty & CometD experts

eclipse.org/jetty - cometd.org

On Wed, Aug 7, 2013 at 3:08 PM, Makc <makc.the.great@xxxxxxxxx> wrote:

I have a question about these lines:

 

https://github.com/eclipse/jetty.project/blob/master/jetty-websocket/websocket-server/src/main/java/org/eclipse/jetty/websocket/server/WebSocketServerFactory.java#L393-L402

 

rfc section 4.2.1 does say that client is expected to send "A |Sec-WebSocket-Version| header field, with a value of 13" and that "If the server, while reading the handshake, finds that the client did not send a handshake that matches the description below... the server MUST stop processing the client's handshake and return an HTTP response with an appropriate error code (such as 400 Bad Request)"

 

jetty's code above does send 400, but note that 400 is only listed as one of "appropriate error codes". Next, section 4.2.2 states this:

 

"/version/
          The |Sec-WebSocket-Version| header field in the client's
          handshake includes the version of the WebSocket Protocol with
          which the client is attempting to communicate.  If this
          version does not match a version understood by the server, the
          server MUST abort the WebSocket handshake described in this
          section and instead send an appropriate HTTP error code (such
          as 426 Upgrade Required) and a |Sec-WebSocket-Version| header
          field indicating the version(s) the server is capable of
          understanding.
"

 

so basically, jetty might reply with 426 and version = 13 instead of 400.

 

The reason I am looking into this is because I have the client here that tries to connect with version 8 and then closes the connection in response to 400. Now if jetty would return 426, the client might retry with version 13, right? I now made the client to start with 13, but decided to ask this here just in case. 

_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/jetty-dev