[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jetty-dev] ClasspathPattern.match
|
Hi,
On Thu, Nov 15, 2012 at 10:50 AM, Eirik Bjørsnøs <eirbjo@xxxxxxxxx> wrote:
>
> Hi,
>
> Should ClasspathPattern.match really be using regular expressions to tweak
> the name parameter before matching?
>
> On one of my apps, this method is called 23204 times at startup.
And how long does it take to start ?
> I haven't done any profiling, but I'm assuming on large classpaths, this
> must be an issue. (My assumption being that regexps are somewhat expensive)
>
> The methods using regexps (String.replaceFirst, String.replaceAll) both seem
> to be easily replaceable with a combination of String.contains and
> String.substring.
>
> wdyt?
That we need profiling data. If turns out to be a problem, we'll fix it.
If you want to profile and report to us, we'll be glad to fix it.
Simon
--
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
----
Finally, no matter how good the architecture and design are,
to deliver bug-free software with optimal performance and reliability,
the implementation technique must be flawless. Victoria Livschitz
