Re: [jetty-dev] Fwd: Test modules in Jetty

[Greg Wilkins <gregw@xxxxxxxxxxx>]

Can you expand on what is the benefit of changing existing tests?



On 3 June 2011 09:33, Michael Gorovoy <michael@xxxxxxxxxxx> wrote:
> Posting the discussion to the mailing lists.
>
> ---------- Forwarded message ----------
> From: Michael Gorovoy <mgorovoy@xxxxxxxxxxx>
> Date: Thu, Jun 2, 2011 at 3:34 PM
> Subject: Re: Test modules in Jetty
> To: Jesse McConnell <jesse@xxxxxxxxxxx>
> Cc: jetty-dev <jetty-dev@xxxxxxxxxxx>
>
>
> While we cannot use the remote assert in Eclipse modules yet, we could
> easily create remote assert webapps for the Eclipse modules that will live
> in the Codehaus repo.
> Holding off the reorganization of modules on the Eclipse side till the time
> we move to Git is a good idea, and we can keep the parent module name as
> 'tests' if everyone likes it better. The Eclipse module names are already
> pretty good with maybe one or two exceptions, but hierarchical organization
> would be a nice thing to have in my opinion.
> It would be great if we could reorganize the Codehaus module names now
> because it is extremely easy to get confused between the dummy modules for
> webapp verifier and real test webapps. However I would totally understand if
> the decision is made to hold it off till the next minor version.
> -Michael
> Michael Gorovoy | mgorovoy@xxxxxxxxxxx | http://www.intalio.com |
>
>
> On Thu, Jun 2, 2011 at 1:13 PM, Jesse McConnell <jesse@xxxxxxxxxxx> wrote:
>>
>> we can't use jetty-remote-assert on the eclipse side at this
>> point...we have CQ issues which prompted us to do it on the codehaus
>> side
>>
>> I am not keen on renaming tests -> test-parent
>>
>> if I had my druthers all the test-* stuff in the top level of jetty
>> would have lived under the tests directory but at this point I don't
>> want to shift artifacts around in the repository...we could move them
>> in scm though and keep the groupId's I suppose...we'll mess with that
>> during the git move.
>>
>> For some context for others not knowing what this is all about:
>>
>> what I would like to see for the remainder of the federal work is the
>> development and conversion of the things in the test-jetty-webapp on
>> the eclipse side into testwars that we can leverage in the
>> test-jetty-distribution akin to the way the test-war-download works...
>>
>> so we can have a series of war files that have a common context
>>
>> localhost:8080/context/testSuite
>>
>> hitting that will return a mess of JSON that describes the results of
>> running tests from the servlet
>>
>> we can iterate through that JSON and validate that all remote tests
>> were successful....in your test-war-download there is now a pojo that
>> has @Test annotations that each attempt to download a file from itself
>> really...normal client connection, etc
>>
>> calling that testSuite servlet will execute all those tests and return
>> the JSON string
>>
>> so the longer term goal is to have all this functionality for all the
>> things we generally test in jetty distribution by hand...jsp support,
>> cometd support, etc etc...all automatically tested when we are
>> building a release so we have  a higher degree of confidence in the
>> release
>>
>> and its all being done on the codehaus side since we don't have to
>> mess with CQ's and whatnot in this early stage
>>
>> cheers,
>> jesse
>
> From: Joakim Erdfelt <joakim@xxxxxxxxxxx>
> Date: Thu, Jun 2, 2011 at 1:11 PM
> Subject: Re: Test modules in Jetty
> To: Michael Gorovoy <mgorovoy@xxxxxxxxxxx>
> Cc: jetty-dev <jetty-dev@xxxxxxxxxxx>
>
> Just to provide some background ...
> the jetty-remote-asserts module that Michael is talking about allows us to
> use the standard Junit TestSuite concepts to wrap up a bunch of standard
> Junit 4 tests within a RemoteAssertsServlet to allow for testing within a
> real container, within the context of a webapp to verify or validate various
> behavior.
> This was created for the SEJetty project to help test behavior within the
> webapps when the various SEJetty specific configurations are in use.
> In many cases below, we don't have to change or modify the existing tests,
> just reference them in a TestSuite that the RemoteAssertsServlet can see.
> - Joakim
>
>>
>> On Thu, Jun 2, 2011 at 11:55 AM, Michael Gorovoy <mgorovoy@xxxxxxxxxxx>
>> wrote:
>> > Following development of the distribution testing and remote assert
>> > capabilities, there's a need to re-organize and convert various existing
>> > test modules to be used for integration testing of Jetty. Below is a
>> > list of
>> > all current test modules, with notes that specify their purpose and
>> > whether
>> > they can be used for integration testing. I would like to propose
>> > renaming
>> > current 'tests' module to 'test-parent' in Eclipse repository, and
>> > consolidating all the test modules under this parent module. I also
>> > would
>> > like to propose renaming the test-wars module in Codehaus repository to
>> > 'testing-parent' and moving all test modules under this parent module. I
>> > suggest that we create a standard of naming the test modules, with
>> > 'test-xxxx' reserved for testing specific features, 'test-app-xxxx'
>> > reserved
>> > for remote assert testing of the respective features, 'dummy-war-yyyy'
>> > reserved for webapp validator test apps, and 'example-app-zzzz' reserved
>> > for
>> > sample and demo apps.
>> > Eclipse:
>> > test-continuation create remote assert webapp
>> > test-continuation-jetty6 create remote assert webapp
>> > test-jetty-nested create remote assert webapp
>> > test-jetty-servlet create remote assert webapp
>> > test-jetty-webapp Demo webapp, create remote assert tests
>> > test-integration create remote assert webapp
>> > test-loginservice create remote assert webapp
>> > test-hash-sessions create remote assert webapp
>> > test-jdbc-sessions create remote assert webapp
>> > test-webapp-rfc2616 ?
>> > Codehaus:
>> > test-annotation-webapp create remote assert tests
>> > test-jaas-webapp ?
>> > test-jetty-distribution integration tests
>> > test-jetty-policy ?
>> > test-jetty-policy-integration Hightide demo webapp
>> > test-jetty-webapp extract tests to remote assert webapp
>> > test-jndi-webapp create remote assert tests
>> > test-war-commons_logging_1.0.3 Dummy app for webapp validator
>> > test-war-commons_logging_1.1 Dummy app for webapp validator
>> > test-war-download remote assert webapp
>> > test-war-dump create remote assert tests
>> > test-war-groovy Dummy app for webapp validator
>> > test-war-java_util_logging Dummy app for webapp validator
>> > test-war-javaversions Dummy app for webapp validator
>> > test-war-jruby Dummy app for webapp validator
>> > test-war-jython Dummy app for webapp validator
>> > test-war-log4j_1.1.3 Dummy app for webapp validator
>> > test-war-log4j_1.2.15 Dummy app for webapp validator
>> > test-war-nativeaccess Dummy app for webapp validator
>> > test-war-policy Dummy app for webapp validator
>> > test-war-scm Dummy app for webapp validator
>> > test-war-servlet23 Dummy app for webapp validator
>> > test-war-servlet24 Dummy app for webapp validator
>> > test-war-servlet25 Dummy app for webapp validator
>> > test-war-servletmixed1 Dummy app for webapp validator
>> > test-war-servletmixed2 Dummy app for webapp validator
>> > test-war-shellscripts Dummy app for webapp validator
>> > test-war-slf4j_1.2 Dummy app for webapp validator
>> > test-war-slf4j_1.5.6 Dummy app for webapp validator
>> > test-war-slf4j_1.6.1 Dummy app for webapp validator
>> > --
>> > Michael Gorovoy
>> > Mobile: 917-512-1765
>> > E-mail: michael@xxxxxxxxxxx
>> > Michael Gorovoy | mgorovoy@xxxxxxxxxxx | http://www.intalio.com |
>>
>>
>>
>> --
>> jesse mcconnell
>> jesse@xxxxxxxxxxx
>
>
>
> _______________________________________________
> jetty-dev mailing list
> jetty-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/jetty-dev
>
>