Re: [jetty-dev] hamcrest?

[Greg Wilkins <gregw@xxxxxxxxxxx>]

Joakim,

I'm happy for it to stay, as it looks like somebody had already done
the work to get it CQ'd, plus it is used by junit 4.x so we indirectly
use it anyway.
I just didn't notice it before as a transitive dependency

cheers






On 31 January 2011 15:04, Joakim Erdfelt <joakim@xxxxxxxxxxx> wrote:
> Jesse is also well aware of this dependency.
> I can remove it.
> Hamcrest is actually built-into the junit 4.8.1 jar file.
> The dependency was just an update to those classes.
> Also, when working with test dependencies, the rules of IP/CQ are lessened.
> The IP/CQ for stuff we use in the build but don't distribute have a much
> lower bar.
> But I'll defer to Jesse for further details...
> - Joakim
> On Sun, Jan 30, 2011 at 9:02 PM, Greg Wilkins <gregw@xxxxxxxxxxx> wrote:
>>
>> Joakim,
>>
>> Oh, looks like we already CQ'd hamcrest:
>>
>>  https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4119
>>
>> It came in with junit 4.5.
>>
>> sorry my bad for not noticing.
>>
>> cheers
>>
>>
>> On 31 January 2011 14:40, Greg Wilkins <gregw@xxxxxxxxxxx> wrote:
>> > Joakim,
>> >
>> > I'm building with the build updated to use jetty-test-helper now.    I
>> > note that it is now using a new dependency: hamcrest?
>> >
>> > I don't recall this being discussed when we talked about the
>> > restructure.  It is vital that all new dependencies are considered
>> > carefully and discussed on the list.
>> > In this case it is for testing, so the barrier is pretty low and it's
>> > almost certainly OK for us to us it, but I think we still need to get
>> > it CQ'd.
>> >
>> > cheers
>> >
>
>
> _______________________________________________
> jetty-dev mailing list
> jetty-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/jetty-dev
>
>