[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[jetty-dev] Re: Character Encoding and Jetty 7

Digging a little deeper, in fact it seems we made this change waaay back for jetty-6.1.12.

Here are the 2 jira issues related to it:

http://jira.codehaus.org/browse/JETTY-633
http://jira.codehaus.org/browse/JETTY-853

I'm not sure why we decided to change to ISO-8859-1 in JETTY-633. No clues in the commit comments as to the reason.

I seem to have commented in the later issue JETTY-853 that in http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.7.1 it
specifies default encoding of ISO-5589-1. But looking at that section now, it only stipulates ISO-8859-1 for Content-Type of "text", so not sure
why I thought that was relevant.


So in short, I don't know why we changed from UTF8 to ISO-5589-1 in the first place, but it seems to have been changed at least since
jetty-6.1.12, so the change has some history to it.


The wiki page at http://docs.codehaus.org/display/JETTY/International+Characters+and+Character+Encodings
seems to be documenting our earlier UTF-8 behaviour.

Do you want to keep it at ISO-8859-1 and I'll update the wiki page, or do you want to change (back) to UTF-8 ?

cheers
Jan



Greg Wilkins wrote:
Jan

I don't think this was done on purpose.
Do you know where the change was made or what is needed to change it
back to UTF-8?

regards



Jan Bartel wrote:
Greg (lists in cc),

Jetty seems to have changed the assumption of the default character set for
form data to be ISO-8859-1, whereas previously jetty assumed UTF-8.

What was the reason for the change? A few people are reporting issues with
jetty-7 that are all due to the change in char-encoding defaults.

The HTML5 draft spec makes it clear that for url encoded form data the
default should be UTF-8:
http://www.w3.org/TR/html5/forms.html#url-encoded-form-data

Note that we have not changed our default for char encoding ofurls in
requests, and still use UTF-8 as per
http://www.w3.org/TR/html40/appendix/notes.html#non-ascii-chars

Do you think we should revert to UTF-8 for form data for jetty-7.0.0 final?

cheers
Jan


-- Jan Bartel, Webtide LLC | janb@xxxxxxxxxxx | http://www.webtide.com