Re: [jetty-dev] Re: [jetty-commit] r285 - in jetty/trunk: . distribution

[Greg Wilkins <gregw@xxxxxxxxxxx>]

Jesse McConnell wrote:
> it is not a terrible thing to have historical directories/artifacts
> around like that...i had hoped that we would get out of the gate and
> were somewhat future proofing ourselves with this latest structure..
> 
> jetty-distribution I rather like because it produces files that are
> clearly jetty distributions when they are copied around (they are what
> we deploy to the eclipse download site atm) and that is clearer then
> simply 'distribution-7.0.0.M2.zip' and 'distribution-7.0.0.M2.tar.gz'
> which is what that artifact would produce now..

OK, you have convinced me on this one.

> and jetty-start is nice as that is what I am using in that jetty run
> jetty plugin version I worked on a while back, the start.jar rename is
> just a convience as that was the established way it has been in jetty
> lands for a long time and a simple tweak to perform in the
> distribution assembly..

Well I guess this can change back as well.

> personally I have like the jetty-* in front of things as it produces
> artifact file names that are clearly jetty-* artifacts that way...and
> doesn't specifically rely on the groupId to give them context...
> 
> and I am also a fan of segmenting things off depending on their
> purposes like the toolchain groupId so that those artifacts are
> clearly over -----> there and not a part of the mainline jetty
> development efforts.  There is enough going on in start (working in
> there right now) and the distribution is the primary released bundle
> of goop for non-maven users so it makes perfect sense to have it there
> it is imo..
> 
> I would be totally +1 for a org.eclipse.jetty.test and
> org.eclipse.jetty.example set of groupId's as well..

the problem with this approach for testing and examples is ordering

If we have a separate group id, then we really need a directory
to match....

But then the unit tests use the test webapp for example.

Most test harnesses should live in real modules, but there are
a few that need their own (eg test-continuation depends on jetty-6
to test portability).

cheers



> --
> jesse mcconnell
> jesse.mcconnell@xxxxxxxxx
> 
> 
> 
> On Tue, May 26, 2009 at 17:53, Greg Wilkins <gregw@xxxxxxxxxxx> wrote:
>>
>> Jesse McConnell wrote:
>>> I really don't like this change here...
>>
>> Jesse,
>>
>> I hear what you are saying about the already released modules.....
>>
>> But what I was trying to achieve was to use the jetty- label only
>> on jetty components.       So the key thing was to move the test
>> and example modules out of their jetty-* names.
>>
>> Then while I was in the renaming frenzy, I thought that jetty-start
>> was wrongly named because it produces start.jar - and the distribution
>> name works well also with the new aggregate module that I'm now
>> working on.
>>
>> Currently my dev directory is:
>>
>> BUILDING.txt
>> INCUBATION.txt
>> LICENSE-APACHE-2.0.txt
>> LICENSE-CONTRIBUTOR/
>> LICENSE-ECLIPSE-1.0.html
>> NOTICE.txt
>> README.txt
>> VERSION.txt
>> aggregate/
>> distribution/
>> example-jetty-embedded/
>> example-async-rest/
>> jetty-ajp/
>> jetty-annotations/
>> jetty-client/
>> jetty-continuation/
>> jetty-deploy/
>> jetty-http/
>> jetty-io/
>> jetty-jaspi/
>> jetty-jmx/
>> jetty-jndi/
>> jetty-plus/
>> jetty-rewrite/
>> jetty-security/
>> jetty-server/
>> jetty-servlet/
>> jetty-servlets/
>> jetty-util/
>> jetty-webapp/
>> jetty-xml/
>> pom.xml
>> start/
>> test-continuation/
>> test-jetty-servlet/
>> test-jetty-webapp/
>>
>>
>> which I think is pretty neat and straight forward.
>>
>> But then I don't think the start and distribution names are that
>> important and they could be renamed back to jetty-start and jetty-distribution.
>> I would then name aggregate jetty-aggregate.      This would work, but
>> the different distribution and aggregate directories would not stand apart.
>>
>>
>> How big a problem is it that we have a few historic modules in maven repositories?
>> We will collect these over time anyway.
>>
>>
>> cheers
>>
>>
>>
>>
>>> We have already published the distribution and start jars into the
>>> maven central repository as jetty-distribution and jetty-start, and
>>> the jetty-start is being renamed start.jar and placed in the usual
>>> place in the distribution so I don't see the value in
>>>
>>> 1) changing this structure in svn
>>> 2) further confusing the o.e.jetty locations in the maven svn repo
>>> with duplicated jetty-distribution and distribution (also jetty-start
>>> and start) directories...
>>>
>>> We need to confirm this is what we want to do before we push another
>>> release with these changes..
>>>
>>> jesse
>>>
>>> --
>>> jesse mcconnell
>>> jesse.mcconnell@xxxxxxxxx
>>>
>>>
>>>
>>> On Mon, May 25, 2009 at 20:44,  <genie@xxxxxxxxxxx> wrote:
>>>> Author: gwilkins
>>>> Date: 2009-05-25 21:44:57 -0400 (Mon, 25 May 2009)
>>>> New Revision: 285
>>>>
>>>> Modified:
>>>>   jetty/trunk/README.txt
>>>>   jetty/trunk/distribution/pom.xml
>>>>   jetty/trunk/start/src/main/resources/org/eclipse/jetty/start/start.config
>>>> Log:
>>>> renamed non runtime modules
>>>>
>>>> Modified: jetty/trunk/README.txt
>>>> ===================================================================
>>>> --- jetty/trunk/README.txt      2009-05-26 01:18:10 UTC (rev 284)
>>>> +++ jetty/trunk/README.txt      2009-05-26 01:44:57 UTC (rev 285)
>>>> @@ -53,10 +53,10 @@
>>>>
>>>>  To run with JSP support
>>>>
>>>> -  java -jar start.jar OPTIONS=Server,deploy,jsp
>>>> +  java -jar start.jar OPTIONS=Server,jsp
>>>>
>>>>  To run with JMX support
>>>>
>>>> -  java -jar start.jar OPTIONS=Server,deploy,jmx etc/jetty-jmx.xml etc/jetty.xml
>>>> +  java -jar start.jar OPTIONS=Server,jmx etc/jetty-jmx.xml etc/jetty.xml
>>>>
>>>>
>>>>
>>>> Modified: jetty/trunk/distribution/pom.xml
>>>> ===================================================================
>>>> --- jetty/trunk/distribution/pom.xml    2009-05-26 01:18:10 UTC (rev 284)
>>>> +++ jetty/trunk/distribution/pom.xml    2009-05-26 01:44:57 UTC (rev 285)
>>>> @@ -5,11 +5,11 @@
>>>>     <artifactId>jetty-project</artifactId>
>>>>     <version>7.0.0.M3-SNAPSHOT</version>
>>>>   </parent>
>>>> -  <artifactId>jetty-distribution</artifactId>
>>>> -  <name>Jetty :: Distribution Assemblies</name>
>>>> +  <artifactId>distribution</artifactId>
>>>> +  <name>Distribution Assemblies</name>
>>>>   <packaging>pom</packaging>
>>>>   <properties>
>>>> -    <assembly.directory>target/assembly-prep</assembly.directory>
>>>> +    <assembly.directory>target/distribution</assembly.directory>
>>>>     <slf4j-version>1.5.6</slf4j-version>
>>>>     <jsp-2-1-version>9.1.1.B60.25.p1</jsp-2-1-version>
>>>>   </properties>
>>>>
>>>> Modified: jetty/trunk/start/src/main/resources/org/eclipse/jetty/start/start.config
>>>> ===================================================================
>>>> --- jetty/trunk/start/src/main/resources/org/eclipse/jetty/start/start.config   2009-05-26 01:18:10 UTC (rev 284)
>>>> +++ jetty/trunk/start/src/main/resources/org/eclipse/jetty/start/start.config   2009-05-26 01:44:57 UTC (rev 285)
>>>> @@ -108,10 +108,10 @@
>>>>  [Server,All,webapp,default]
>>>>  $(jetty.home)/lib/jetty-webapp-$(version).jar                                           ! available org.eclipse.jetty.webapp.WebAppContext
>>>>
>>>> -[All,deploy,default]
>>>> +[Server,All,deploy,default]
>>>>  $(jetty.home)/lib/jetty-deploy-$(version).jar                                           ! available org.eclipse.jetty.deploy.ContextDeployer
>>>>
>>>> -[All,servlets,default]
>>>> +[Server,All,servlets,default]
>>>>  $(jetty.home)/lib/jetty-servlets-$(version).jar                                         ! available org.eclipse.jetty.servlets.WelcomeFilter
>>>>
>>>>  [All,rewrite]
>>>>
>>>> _______________________________________________
>>>> jetty-commit mailing list
>>>> jetty-commit@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/jetty-commit
>>>>
>>> _______________________________________________
>>> jetty-dev mailing list
>>> jetty-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/jetty-dev
>> _______________________________________________
>> jetty-dev mailing list
>> jetty-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/jetty-dev
>>
> _______________________________________________
> jetty-dev mailing list
> jetty-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/jetty-dev