[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jdt-ui-dev] SubMonitor adoption in JDT UI
|
Thanks Stefan.We will look at this during M5. Next
week is the last week of development for M4 and Noopur is on vacation.DaniFrom:
Stefan Xenos <sxenos@xxxxxxxxxx>To:
"Eclipse JDT UI
developers list." <jdt-ui-dev@xxxxxxxxxxx>Date:
24.11.2016 02:01Subject:
Re: [jdt-ui-dev]
SubMonitor adoption in JDT UISent by:
jdt-ui-dev-bounces@xxxxxxxxxxx
I've finished reviewing Lars' patch. He's sorted out all
the issues I found from visual inspection. It could use the attention of
a JDT UI committer now.
On Fri, Nov 18, 2016 at 4:25 AM Lars Vogel <lars.vogel@xxxxxxxxxxx>
wrote:Hi,I added Stefan Xenos as reviewer of the Gerrit reviews.
Stefan as creator and maintainer of the new SubMonitor API should be a
trustful person for these reviews.Best regards, LarsOn Thu, Nov 17, 2016 at 3:11 PM, Markus Keller <markus_keller@xxxxxxxxxx>
wrote:Sorry, I should have made it more clear
that my response was specific to this request and this contributor.
A big amount of my work time is wasted
on reviewing and reverting such changes. Instead of silently ignoring this
request, I wanted to explain why this bug wasn't given priority.
We do welcome high-quality contributions.
Markus
From: "Markov,
Veselin" <Markov@xxxxxxxxx>
To: "Eclipse
JDT UI developers list." <jdt-ui-dev@xxxxxxxxxxx>
Date: 2016-11-17
14:44
Subject: Re:
[jdt-ui-dev] SubMonitor adoption in JDT UI
Sent by: jdt-ui-dev-bounces@xxxxxxxxxxx
Hello Markus,
If I were you I’d give a second thought before answering a review request
from a contributor.
You just accused contributors of being incompetent and lazy and said there
is no point of contributing to eclipse because the changes won’t be reviewed
anyway.
Mit freundlichen Grüßen / Best regards
Veselin Markov| Systemhaus
für Sicherheitstechnik und Softwareentwicklung |
| Entwicklungsleiter |
| GEMTEC
GmbH, Am Möllenberg 37, 15713 Königs Wusterhausen |
Homepage: www.gemtec.eu|
www.wotanex.de
Sitz der Gesellschaft: Königs Wusterhausen OT Niederlehme
Geschäftsführer: Nils Burschik,
Jan Burschik, Jens Krönert, Sven Lauritsen
Handelsregister: Amtsgericht Cottbus
HRB 9452 CB
___________________________________________________________
Diese E-Mail (inklusive aller Anhänge) enthält vertrauliche und/oder rechtlich
geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder
diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den
Absender und vernichten Sie diese E-Mail. Das unerlaubte Lesen, Kopieren
sowie die unbefugte Weitergabe, aber auch das Verwenden oder der Transfer
von Informationen aus dieser E-Mail ist unter Bezug auf die aktuelle Rechtsprechung
nicht gestattet. Bitte beachten Sie, dass E-Mails an die persönliche E-Mail-Adresse
des Absenders nicht regelmäßig kontrolliert werden und daher E-Mails für
fristgebundene Inhalte nicht geeignet sind. Wir weisen ausdrücklich darauf
hin, dass zum rechtsgültigen Abschluss von Verträgen ausschließlich Dokumente
geeignet sind, die die rechtsgültigen Unterschriften der Vertretungsberechtigten
unseres Unternehmens enthalten. Vielen Dank.
Von: jdt-ui-dev-bounces@xxxxxxxxxxx[mailto:jdt-ui-dev-bounces@xxxxxxxxxxx]
Im Auftrag von Markus Keller
Gesendet: Donnerstag, 17. November 2016 12:36
An: Eclipse JDT UI developers list.
Betreff: Re: [jdt-ui-dev] SubMonitor adoption in JDT UI
Such "fairly simple" changes break things in 80% of the cases,
because the contributor didn't give enough attention to details.
We don't have the resources or motivation to do the necessary thorough
review for such contributions, given that we don't expect functional benefits
for users.
Markus
From: Stefan
Xenos <sxenos@xxxxxxxxxx>
To: jdt-ui-dev@xxxxxxxxxxx,
Lars Vogel <lars.vogel@xxxxxxxxxxx>
Date: 2016-11-15
19:42
Subject: [jdt-ui-dev]
SubMonitor adoption in JDT UI
Sent by: jdt-ui-dev-bounces@xxxxxxxxxxx
Hi!
Lars has a number of outstanding reviews in the JDT UI project related
to adoption of SubMonitor. They're fairly simple and have been sitting
in the review queue for over a year.
It would be helpful if someone could look at these reviews, since further
adoption of SubMonitor would let me run the automated analysis tools to
look for progress monitoring bugs in JDT UI.
https://git.eclipse.org/r/#/c/57921/
https://git.eclipse.org/r/#/c/57920/
https://git.eclipse.org/r/#/c/57875/
- Stefan_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
--
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx,
Web: http://www.vogella.com
_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev[attachment
"attctr9w.png" deleted by Daniel Megert/Zurich/IBM] [attachment
"attlkuw6.jpg" deleted by Daniel Megert/Zurich/IBM] [attachment
"attv61qo.png" deleted by Daniel Megert/Zurich/IBM] [attachment
"atthqn2h.png" deleted by Daniel Megert/Zurich/IBM] [attachment
"attnypas.png" deleted by Daniel Megert/Zurich/IBM] _______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
