Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-ui-dev] Re: [jdt-core-dev] Field references

The naming in the UI has been changed accordingly and the following constants are being used now by Java Search UI:
        IJavaSearchConstants.READ_REFERENCES -> IJavaSearchConstants.READ_ACCESSES
        IJavaSearchConstants.WRITE_REFERENCES -> IJavaSearchConstants.WRITE_ACCESSES

Dani


"Erich Gamma/ZRH/OTI" <Erich_Gamma@xxxxxxx>
Sent by: jdt-ui-dev-admin@xxxxxxxxxxx

11/14/01 03:16 PM
Please respond to jdt-ui-dev

       
        To:        jdt-core-dev@xxxxxxxxxxx
        cc:        jdt-ui-dev@xxxxxxxxxxx
        Subject:        [jdt-ui-dev] Re: [jdt-core-dev] Field references



The original reporter of the problem is serving the Swiss Armee so he can't
comment for some time.

The proposal makes sense to me. The search page should
then change the labels as follows:
Read References -> Read Access
Write References -> Write Access

This avoids the implicit rule.

--erich



                                                                                                                               
                   "Jerome                                                                                                    
                   Lanneluc/SNZ/OTI"           To:     jdt-core-dev@xxxxxxxxxxx, jdt-ui-dev@xxxxxxxxxxx                        
                   <Jerome_Lanneluc@oti        cc:                                                                            
                   .com>                       Subject:     [jdt-core-dev] Field references                                    
                   Sent by:                                                                                                    
                   jdt-core-dev-admin@e                                                                                        
                   clipse.org                                                                                                  
                                                                                                                               
                                                                                                                               
                   14.11.2001 11:42                                                                                            
                   Please respond to                                                                                          
                   jdt-core-dev                                                                                                
                                                                                                                               
                                                                                                                               



Right now, you can search for field references in 3 ways:
- IJavaSearchConstants.REFERENCES: all references to a field are reported
(this does not include field declarations)
- IJavaSearchConstants.READ_REFERENCES: all read references to a field are
reported (this does not include field declarations, or field
modifications)
- IJavaSearchConstants.WRITE_REFERENCES: all write references to a field
are
reported (this does not include field declarations - even if the field has
an initializer)

However, bug 5563: 'Write reference on declaration not reported' made us
realize that what you really want in the 3rd case is the field
modifications (including field initializations). In this case, the
following implicit rule REFERENCES = READ_REFERENCES +  WRITE_REFERENCES
is false.

I propose to change the last 2 constants to:
- IJavaSearchConstants.READ_ONLY: all read access to a field are reported
(this does not include field declarations, or field modifications)
- IJavaSearchConstants.MODIFICATIONS: all field modifications (including
initializations) to a field are reported.

And the implicit rule disappears because there is no notion of reference
in this last 2 constants.

The Java Search page would have to be modified accordingly.

Comments are welcome (please respond to jdt-core-dev@xxxxxxxxxxx).

Jerome
_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/jdt-core-dev




_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/jdt-ui-dev

Back to the top