Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[jdt-dev] Should classpath deltas contain attribute changes?

Hi all,

tl;dr

Does it make sense to add changed classpath attributes to classpath deltas? Currently they are not directly included.

Background:

We recently ran into this issue: https://github.com/eclipse-jdt/eclipse.jdt.core/issues/486

Essentially, we had frequent JavaDoc location changes due to a bug, which resulted in classpath deltas like this:

xxxx[*]:
{RESOLVED CLASSPATH CHANGED}

This delta is created by ClasspathChange.generateDelta() as the old and new classpaths differ according to JavaProject.areClasspathsEqual(). generateDelta() however doesn't "flesh out" the delta with the changes.

So, there is not enough information in such deltas. We would like to add more, so that our product doesn't "overreact" to irrelevant classpath changes. This would mean two things:

1. Adding a new flag in IJavaElementDelta, i.e. new API.
2. The now mostly empty delta will have children, some clients might change behavior due to that.

From our POV (me, Andrey, Christian, see CC), a delta like the above should not exist. It should either not be sent, since apparently there is nothing of interest that changed (as there are no delta children). Or, the delta should contain the classpath entries that changed. We assume the latter is the better option.

What do JDT devs think about this?

Best regards and thanks,
Simeon

Back to the top