[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [jdt-dev] Bugzilla vs. Gerrit
|
I *never* recommend Eric (or anyone else) to provide Gerrits *instead* of reporting bugs.
I prefer to have bugs reported first, not only in JDT project.
Independently to this, I also prefer that non trivial commits (with or without bug) have an appropriate commit message describing the fix.
Am 23. Februar 2020 12:58:44 MEZ schrieb Stephan Herrmann <stephan.herrmann@xxxxxxxxx>:
>Hi Team,
>
>I wondered about a batch of gerrit changes recently created by Eric
>Milles, some
>of which gave no obvious reasons why a fix was needed in the first
>place. So on
>one gerrit I asked him "why?" and he responded:
>"Andrey Lusktov and Lars Vogel have repeatedly asked me to submit
>gerrit
>changes instead of opening bugs with proposed fixes/patches."
>
>I haven't asked Andrey and Lars whether indeed they said "instead of",
>and I
>haven't asked him if they spoke about Platform specifically or all of
>Eclipse,
>but I think the JDT team should speak in one voice in such matters.
>
>I personally prefer to use bugzilla first and work with gerrits only
>for working
>out the details towards an agreed-upon goal. And in fact I believe the
>option to
>use gerrit without bugzilla was intended only for trivial changes
>obviously not
>needing a discussion, wasn't it?
>
>I would even vote to keep the gerrit-only approach only for committers
>and route
>all incoming JDT contributions through bugzilla.
>
>Finally, I think it's important that every committer can easily see,
>whenever
>communication already happened between a committer and a contributor,
>to the end
>that we don't annoy contributors with contradictory requests.
>
>What do others think?
>
>best,
>Stephan
>
>PS: There's also the issue of separating real fixes from "style
>cleanup", but I
>think we already agree that both kinds of changes should never be mixed
>in a
>single contribution.
>_______________________________________________
>jdt-dev mailing list
>jdt-dev@xxxxxxxxxxx
>To change your delivery options, retrieve your password, or unsubscribe
>from this list, visit
>https://www.eclipse.org/mailman/listinfo/jdt-dev
--
Kind regards,
Andrey Loskutov
https://www.eclipse.org/user/aloskutov
Спасение утопающих - дело рук самих утопающих