Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-core-dev] [platform-releng-dev] 4.8.0I-Build:I20180127-0150
We can download an archive with the differences from
http://download.eclipse.org/eclipse/downloads/drops4/I20180128-2000/buildlogs.php
This zip includes the baseline and the current version in text form so that it's very easy to compare and spot the differences

I looked at all the differences and can confirm that they are indeed because of the change for bug 521182 and are expected.

Regards
Sasikanth

-----jdt-core-dev-bounces@xxxxxxxxxxx wrote: -----
To: jdt-core-dev@xxxxxxxxxxx
From: Stephan Herrmann
Sent by: jdt-core-dev-bounces@xxxxxxxxxxx
Date: 01/29/2018 03:56AM
Subject: Re: [jdt-core-dev] [platform-releng-dev] 4.8.0 I-Build:I20180127-0150

Maybe I misunderstood something, but the following approach didn't help:

Download
- eclipse-SDK-I20180127-0150-linux-gtk-x86_64.tar.gz
- eclipse-SDK-4.8M5-linux-gtk-x86_64.tar.gz
Extract from both: org.eclipse.jface_3.14.0.v20180123-2012.jar
Already the jar has the exact same bytes in both downloads.
(I Noticed this after extracting and comparing classes from both).

Then I looked closer at the report:
1.  eclipse.platform.ui/bundles/org.eclipse.jface
    no-classifier: different
       org/eclipse/jface/resource/ImageDataImageDescriptor.class: different
       org/eclipse/jface/util/BidiUtils.class: different
       org/eclipse/jface/viewers/ViewerColumn.class: different
     The main artifact has been replaced with the baseline version.
     The following attached artifacts have been replaced with the baseline version: [pack200, sources]
Doesn't that mean the download contains the base line artifact,
and so I never had the suspect in my hands?

Then I fetched the following file from build.eclipse.org:
/opt/public/eclipse/builds/4I/gitCache/eclipse.platform.releng.aggregator/eclipse.platform.ui/bundles/org.eclipse.jface/target/classes/org/eclipse/jface/resource/ImageDataImageDescriptor.class

Comparing output of javap -p -v -c I saw this CHANGE:

   org.eclipse.jface.resource.ImageDataImageDescriptor(org.eclipse.swt.graphics.Image);
     descriptor: (Lorg/eclipse/swt/graphics/Image;)V
     flags:
     Code:
       stack=3, locals=2, args_size=2
          0: aload_0
          1: aload_1
// CHANGE START:
          2: dup
          3: invokevirtual #12                 // Method java/lang/Object.getClass:()Ljava/lang/Class;
          6: pop
//
          7: invokedynamic #21,  0             // InvokeDynamic
#0:getImageData:(Lorg/eclipse/swt/graphics/Image;)Lorg/eclipse/swt/graphics/ImageDataProvider;
         12: invokespecial #22                 // Method "<init>":(Lorg/eclipse/swt/graphics/ImageDataProvider;)V
         15: aload_0
         16: aload_1
         17: putfield      #25                 // Field originalImage:Lorg/eclipse/swt/graphics/Image;
         20: return
       LineNumberTable:
         line 37: 0
         line 38: 15
         line 39: 20
       LocalVariableTable:
         Start  Length  Slot  Name   Signature
             0      21     0  this   Lorg/eclipse/jface/resource/ImageDataImageDescriptor;
             0      21     1 originalImage   Lorg/eclipse/swt/graphics/Image;

Telling me that https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.eclipse.org_521182&d=DwIF-g&c=jf_iaSHvJObTbx-siA1ZOg&r=o963LG-v40yVK_FFyn8Arh6uH3v-wImwnF-gopa6FwA&m=16iIN1DmmzH0d8DcXRxi4jGYUd3jb7jr3Ulq30qFadw&s=72NEnoaoHdI7C5hJkwSRNauGYEC2w0YhenU3f6a-lM8&e= had kicked in as designed.
Apart from that I saw many things changed order and the constant pool
looks entirely different. So, yes, there is an expected change.
No, I can't easily tell if that's the only change.
Also I only looked into one of the changed classes.

HTH,
Stephan

On 27.01.2018 17:52, Daniel Megert wrote:
> Hi Stephan
>
> Yes, you can simply compare the class files that are reported as being different. You can just compare the class files in the M5
> download with the ones from the latest builds where the errors are reported. No need to set up a workspace.
>
> Dani
>
>
>
> From: Stephan Herrmann <stephan.herrmann@xxxxxxxxx>
> To: Daniel Megert <daniel_megert@xxxxxxxxxx>, Eclipse JDT Core developers list <jdt-core-dev@xxxxxxxxxxx>
> Date: 27.01.2018 12:45
> Subject: Re: [jdt-core-dev] [platform-releng-dev] 4.8.0 I-Build:  I20180127-0150
> Sent by: jdt-core-dev-bounces@xxxxxxxxxxx
> ------------------------------------------------------------------------------------------------------------------------------------
>
>
>
> I could look into it if not too much preparation / setup needed.
> Is there some routine for such investigation?
> - compare class files from current & previous builds?
>    - how would I identify the version used as baseline?
>    - what does "no-classifier" in the log mean?
> - setup dev workspace of affected project and locally compile
>    using different versions of ecj?
> What's the quickest approach?
>
> best,
> Stephan
>
> On 27.01.2018 11:10, Daniel Megert wrote:
>>> Is this caused by the move to M5 jdt.core?
>>
>> Either that (compiler produces different class file for same source)  or some dependent files e.g. changed a constant value.
>>
>> JDT Core team, please investigate.
>>
>> Thanks,
>> Dani
>>
>>
>>
>> From: Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
>> To: "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx>
>> Date: 27.01.2018 10:35
>> Subject: Re: [platform-releng-dev] 4.8.0 I-Build: I20180127-0150
>> Sent by: platform-releng-dev-bounces@xxxxxxxxxxx
>> ------------------------------------------------------------------------------------------------------------------------------------
>>
>>
>>
>> Is this caused by the move to M5 jdt.core? Can JDT committer comment
>> on what should be done here?
>>
>> On Sat, Jan 27, 2018 at 10:42 AM,  <genie.releng@xxxxxxxxxxx>  wrote:
>>> Eclipse downloads:
>>>    https://urldefense.proofpoint.com/v2/url?u=http-3A__download.eclipse.org_eclipse_downloads_drops4_I20180127-2D0150_&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JbeIO9Z3E4VfRI780Dg-EwmPvyjIQsqY_AJAexm9I1E&s=xz8Km1g53FrmH6J6q8q21aqxihoknW-Vvn2YLzQPMcg&e=
>>>
>>>    Build logs and/or test results (eventually):
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__download.eclipse.org_eclipse_downloads_drops4_I20180127-2D0150_testResults.php&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JbeIO9Z3E4VfRI780Dg-EwmPvyjIQsqY_AJAexm9I1E&s=vn_f8Sb_oMGGhjGN1x5VPJh5X5N1pqJADpM80zagUjY&e=
>>>
>>>    Check unanticipated comparator messages:
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__download.eclipse.org_eclipse_downloads_drops4_I20180127-2D0150_buildlogs_comparatorlogs_buildtimeComparatorUnanticipated.log.txt&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JbeIO9Z3E4VfRI780Dg-EwmPvyjIQsqY_AJAexm9I1E&s=XgO7vE9PO4vhWMZmcAJw6PME5nZGfiduovtUHNYGyPU&e=
>>>
>>> Software site repository:
>>>    https://urldefense.proofpoint.com/v2/url?u=http-3A__download.eclipse.org_eclipse_updates_4.8-2DI-2Dbuilds&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JbeIO9Z3E4VfRI780Dg-EwmPvyjIQsqY_AJAexm9I1E&s=if3G5m7GLvAHapLEtmf4Kczr8HfgesriyzaxfEnb3v8&e=
>>>
>>> Specific (simple) site repository:
>>>    https://urldefense.proofpoint.com/v2/url?u=http-3A__download.eclipse.org_eclipse_updates_4.8-2DI-2Dbuilds_I20180127-2D0150&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JbeIO9Z3E4VfRI780Dg-EwmPvyjIQsqY_AJAexm9I1E&s=hjRKV18rw4Ssi1tAzY4UM0az_gnR3NSgsrxAobEa4bg&e=
>>>
>>> Equinox downloads:
>>>    https://urldefense.proofpoint.com/v2/url?u=http-3A__download.eclipse.org_equinox_drops_I20180127-2D0150&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JbeIO9Z3E4VfRI780Dg-EwmPvyjIQsqY_AJAexm9I1E&s=a84408PxD1Ee7EGJLRAXJuhxD64VWTRLdcbH9HVOiHc&e=
>>>
>>>
>>> _______________________________________________
>>> platform-releng-dev mailing list
>>> platform-releng-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe   from
>>> this list, visit
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_platform-2Dreleng-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JbeIO9Z3E4VfRI780Dg-EwmPvyjIQsqY_AJAexm9I1E&s=zBBYTwzj7DSCnJVsGMxwn-8812ZdzP4vg6wK07oxnqo&e=
>>
>>
>>
>> --
>> Alexander Kurtakov
>> Red Hat Eclipse Team
>> _______________________________________________
>> platform-releng-dev mailing list
>> platform-releng-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe  from this list, visit
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_platform-2Dreleng-2Ddev&d=DwICAg&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=JbeIO9Z3E4VfRI780Dg-EwmPvyjIQsqY_AJAexm9I1E&s=zBBYTwzj7DSCnJVsGMxwn-8812ZdzP4vg6wK07oxnqo&e=
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> platform-releng-dev mailing list
>> platform-releng-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe  from this list, visit
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_platform-2Dreleng-2Ddev&d=DwIF-g&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=ERsyUW3TGbtLqJuK13eIk4NRXZgLd6-Nmg76h2sMeAc&s=JHmOk_44f0ne6Uma-PZqakatBy-Rb3DqMmsavqwMUao&e=
>>
>
> _______________________________________________
> jdt-core-dev mailing list
> jdt-core-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_jdt-2Dcore-2Ddev&d=DwIF-g&c=jf_iaSHvJObTbx-siA1ZOg&r=1UITCR5rxUZHSFczvfaNFK4ymEbEiccRX7VKchpqz0Y&m=ERsyUW3TGbtLqJuK13eIk4NRXZgLd6-Nmg76h2sMeAc&s=qnMxRbmWc1rUL_CnFecfB5TiCmcsTcoR0-4YHFVY3pA&e=
>
>
>
>
>
>
> _______________________________________________
> jdt-core-dev mailing list
> jdt-core-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_jdt-2Dcore-2Ddev&d=DwIF-g&c=jf_iaSHvJObTbx-siA1ZOg&r=o963LG-v40yVK_FFyn8Arh6uH3v-wImwnF-gopa6FwA&m=16iIN1DmmzH0d8DcXRxi4jGYUd3jb7jr3Ulq30qFadw&s=6tu6H0NMjkYoKh4rSkRozF2E9konuJyYHE1QCVcIg-M&e=
>

_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_jdt-2Dcore-2Ddev&d=DwIF-g&c=jf_iaSHvJObTbx-siA1ZOg&r=o963LG-v40yVK_FFyn8Arh6uH3v-wImwnF-gopa6FwA&m=16iIN1DmmzH0d8DcXRxi4jGYUd3jb7jr3Ulq30qFadw&s=6tu6H0NMjkYoKh4rSkRozF2E9konuJyYHE1QCVcIg-M&e=


Back to the top