Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-core-dev] Plan for merging a / the new lookup? 
I decided for merging bug 517808 before merging master
(hoping for fewer conflicts this way, actually).

I was going to ask about our strategy any way:
Do we have any means to reduce the changes put into master for the
final stretch towards Java 9 GA? I.e., can we emphasize even more
that BETA_JAVA9 is the main strand of development?
(I'm aware that I'm the newcomer in BETA_JAVA9 who may have caused
merge conflicts by putting changes into master in the past ...)
I'm thinking also of changes like https://git.eclipse.org/r/97434
Should this be put into BETA_JAVA9 instead of master at this point?

Do we know how Java 9 GA and Oxygen.1 fit into our schedule?

Anyway, back to the code: As mentioned, bug 517808 brings a lot of
FIXMEs and TODOs (tagged with (SHMOD) to be easily recognizable among
the pile of fixmes and todos).
If you have an opinion on any of those please don't be shy to comment
or just grab and resolve them - Sasi, I'm looking particularly in
your direction :)
For anything bigger than a few minutes, we might just drop a comment
"I'm working on fixme xyz", which from my pov should be enough
synchronization at this point, OK?

Also: do you have any additional tests lingering in Gerrit or elsewhere
that we may want to push now in order to harden the implementation?

cheers,
Stephan


On 05.07.2017 11:08, Manoj Palat wrote:

Stephan/Sasi,
One point: It might be a good idea to merge master with BETA_JAVA9 before the lookup changes are merged. Leave it your discretion to decide on this . 

Regards,
Manoj
Inactive hide details for "Sasikanth B Ammanamanchi" ---07/05/2017 11:21:38 AM---+1, the sooner the better :-) Thanks and Rega"Sasikanth B Ammanamanchi" ---07/05/2017 11:21:38 AM---+1, the sooner the better :-) Thanks and Regards 

From: "Sasikanth B Ammanamanchi" <sasikanth.bharadwaj@xxxxxxxxxx>
To: "Eclipse JDT Core developers list." <jdt-core-dev@xxxxxxxxxxx>
Date: 07/05/2017 11:21 AM
Subject: Re: [jdt-core-dev] Plan for merging a / the new lookup?
Sent by: jdt-core-dev-bounces@xxxxxxxxxxx

------------------------------------------------------------------------------------------------------------------------------------



+1, the sooner the better :-)

Thanks and Regards
Sasikanth
_
__-----jdt-core-dev-bounces@eclipse.org_ <mailto:-----jdt-core-dev-bounces@xxxxxxxxxxx>wrote: -----
To: _jdt-core-dev@eclipse.org_ <mailto:jdt-core-dev@xxxxxxxxxxx>
From: "Jayaprakash Arthanareeswaran"
Sent by: _jdt-core-dev-bounces@eclipse.org_ <mailto:jdt-core-dev-bounces@xxxxxxxxxxx>
Date: 07/05/2017 10:31AM
Cc: _jdt-core-dev@eclipse.org_ <mailto:jdt-core-dev@xxxxxxxxxxx>
Subject: Re: [jdt-core-dev] Plan for merging a / the new lookup?

Stephan,

I am fine with the change going in too. Right now, I just pulled your gerrit patch and working on my APT changes on top of that.
So far, things look good. I may have one or two follow up items, which I will let you know by means of bugs.

Otherwise, it will make it easier for me to have the changes coming from master.

So, let's wait to hear from Sasi.

Regards,
Jay

----- Original message -----
From: Stephan Herrmann <_stephan.herrmann@berlin.de_ <mailto:stephan.herrmann@xxxxxxxxx>>
Sent by: _jdt-core-dev-bounces@eclipse.org_ <mailto:jdt-core-dev-bounces@xxxxxxxxxxx>
To: _jdt-core-dev@eclipse.org_ <mailto:jdt-core-dev@xxxxxxxxxxx>
Cc:
Subject: Re: [jdt-core-dev] Plan for merging a / the new lookup?
Date: Wed, Jul 5, 2017 3:44 AM

Hi Manoj,

So we agree on the priority, great.

Just today I have crunched almost all remaining bugs detected by our tests :)
See the bug for details.

In order to make haste slowly, I'll give it one more day.
If anybody, in particular Sasi has any uneasy feelings, now is the good
time to make them public. If I don't hear any "please hold", I intend to
push it all late on Wednesday or early Thursday.

Until then I would be happy indeed, if compiler is considered frozen
for unrelated commits. Also stuff relating to name environments, please.

After the merge the bug will remain open for some more days, to wrap up
some issues that have already been raised.

There's also enough FIXMEs in the code to fill half a dozen of follow-up bugs.

thanks,
Stephan


On 04.07.2017 16:01, Manoj Palat wrote:
 > Hi Stephan,
 > I would put a high priority for merging this as soon as it is approx at par with HEAD wrt tests.. Since lookup would affect anything
 > and everything in jdt.core, an early merge would help us to iron out any issues arising out of this as soon as possible.
 >
 > If you would like the rest of the jdt.core committers to hold our commits for a day or two, that can also be done so that this major
 > chunk of change does not have to deal with merge conflict resolution-retest cycle.
 >
 > Regards,
 > Manoj
 >
 > Inactive hide details for Stephan Herrmann ---07/04/2017 04:59:17 PM---Hi Team, A lot of changes have accumulated in bug
 > 517808Stephan Herrmann ---07/04/2017 04:59:17 PM---Hi Team, A lot of changes have accumulated in bug 517808 [1][2].
 >
 > From: Stephan Herrmann <_stephan.herrmann@berlin.de_ <mailto:stephan.herrmann@xxxxxxxxx>>
 > To: "Eclipse JDT Core developers list." <_jdt-core-dev@eclipse.org_ <mailto:jdt-core-dev@xxxxxxxxxxx>>
 > Date: 07/04/2017 04:59 PM
 > Subject: [jdt-core-dev] Plan for merging a / the new lookup?
 > Sent by: _jdt-core-dev-bounces@eclipse.org_ <mailto:jdt-core-dev-bounces@xxxxxxxxxxx>
 >
 > ------------------------------------------------------------------------------------------------------------------------------------
 >
 >
 >
 > Hi Team,
 >
 > A lot of changes have accumulated in bug 517808 [1][2].
 >
 > I kindly ask to put priority on
 >
 > - deciding whether this approach is suitable for the task
 >
 > - merging the change as soon as it is approx. on a par with HEAD wrt tests
 >
 > - testing
 >
 > - fine tuning for all relevant corner cases
 >
 > OTOH, I wouldn't want to merge this, if anyone feels uneasy about
 > the big change.
 >
 > Still some reasons for pushing this: several other bugs touch areas
 > that have been significantly changed in bug 517808, so we are at risk
 > of solving the same problems twice. Also, anything that goes into
 > BETA_JAVA9 at this point, potentially causes merge conflict in
 > bug 517808 that cannot be resolved mechanically.
 >
 > Do you have any other priorities before we can address this?
 >
 > thanks,
 > Stephan
 >
 > PS: I'm happy to see the cleanup of test failures in BETA_JAVA9 -
 > trying to catch up in my bug as well. At this point results from
 > Jenkins are a bit more complete, since more test suites are run.
 > Still I don't see any traces of JDK9 being used on Jenkins.
 > Notably:
 >     [INFO] Toolchain in tycho-eclipserun-plugin: JDK[/opt/public/common/jdk1.8.0_x64-latest/jre]
 > Has Sravan recovered from the release, so we can ask him for help? :)
 >
> [1] _https://bugs.eclipse.org/517808_ - [9][compiler] Implement lookup (module, package, type) based on the 2017-05-25 version of JLS 
 > [2] _https://git.eclipse.org/r/98621_
 > _______________________________________________
 > jdt-core-dev mailing list
 > _jdt-core-dev@eclipse.org_ <mailto:jdt-core-dev@xxxxxxxxxxx>
 > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
 > _https://dev.eclipse.org/mailman/listinfo/jdt-core-dev_
 >
 >
 >
 >
 >
 >
 > _______________________________________________
 > jdt-core-dev mailing list
 > _jdt-core-dev@eclipse.org_ <mailto:jdt-core-dev@xxxxxxxxxxx>
 > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
 > _https://dev.eclipse.org/mailman/listinfo/jdt-core-dev_
 >

_______________________________________________
jdt-core-dev mailing list_
__jdt-core-dev@eclipse.org_ <mailto:jdt-core-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or unsubscribe from this list, visit_
__https://dev.eclipse.org/mailman/listinfo/jdt-core-dev_



_______________________________________________
jdt-core-dev mailing list_
__jdt-core-dev@eclipse.org_ <mailto:jdt-core-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or unsubscribe from this list, visit_
__https://dev.eclipse.org/mailman/listinfo/jdt-core-dev_
_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-core-dev




_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-core-dev

Back to the top