[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jdt-core-dev] Plan for merging a / the new lookup?
|
Hi Manoj,
So we agree on the priority, great.
Just today I have crunched almost all remaining bugs detected by our tests :)
See the bug for details.
In order to make haste slowly, I'll give it one more day.
If anybody, in particular Sasi has any uneasy feelings, now is the good
time to make them public. If I don't hear any "please hold", I intend to
push it all late on Wednesday or early Thursday.
Until then I would be happy indeed, if compiler is considered frozen
for unrelated commits. Also stuff relating to name environments, please.
After the merge the bug will remain open for some more days, to wrap up
some issues that have already been raised.
There's also enough FIXMEs in the code to fill half a dozen of follow-up bugs.
thanks,
Stephan
On 04.07.2017 16:01, Manoj Palat wrote:
Hi Stephan,
I would put a high priority for merging this as soon as it is approx at par with HEAD wrt tests.. Since lookup would affect anything
and everything in jdt.core, an early merge would help us to iron out any issues arising out of this as soon as possible.
If you would like the rest of the jdt.core committers to hold our commits for a day or two, that can also be done so that this major
chunk of change does not have to deal with merge conflict resolution-retest cycle.
Regards,
Manoj
Inactive hide details for Stephan Herrmann ---07/04/2017 04:59:17 PM---Hi Team, A lot of changes have accumulated in bug
517808Stephan Herrmann ---07/04/2017 04:59:17 PM---Hi Team, A lot of changes have accumulated in bug 517808 [1][2].
From: Stephan Herrmann <stephan.herrmann@xxxxxxxxx>
To: "Eclipse JDT Core developers list." <jdt-core-dev@xxxxxxxxxxx>
Date: 07/04/2017 04:59 PM
Subject: [jdt-core-dev] Plan for merging a / the new lookup?
Sent by: jdt-core-dev-bounces@xxxxxxxxxxx
------------------------------------------------------------------------------------------------------------------------------------
Hi Team,
A lot of changes have accumulated in bug 517808 [1][2].
I kindly ask to put priority on
- deciding whether this approach is suitable for the task
- merging the change as soon as it is approx. on a par with HEAD wrt tests
- testing
- fine tuning for all relevant corner cases
OTOH, I wouldn't want to merge this, if anyone feels uneasy about
the big change.
Still some reasons for pushing this: several other bugs touch areas
that have been significantly changed in bug 517808, so we are at risk
of solving the same problems twice. Also, anything that goes into
BETA_JAVA9 at this point, potentially causes merge conflict in
bug 517808 that cannot be resolved mechanically.
Do you have any other priorities before we can address this?
thanks,
Stephan
PS: I'm happy to see the cleanup of test failures in BETA_JAVA9 -
trying to catch up in my bug as well. At this point results from
Jenkins are a bit more complete, since more test suites are run.
Still I don't see any traces of JDK9 being used on Jenkins.
Notably:
[INFO] Toolchain in tycho-eclipserun-plugin: JDK[/opt/public/common/jdk1.8.0_x64-latest/jre]
Has Sravan recovered from the release, so we can ask him for help? :)
[1] https://bugs.eclipse.org/517808 - [9][compiler] Implement lookup (module, package, type) based on the 2017-05-25 version of JLS
[2] https://git.eclipse.org/r/98621
_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-core-dev
_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-core-dev
