Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-core-dev] Minimal-change policy?

I also see no Save Actions enabled. So either it's Oomph, or some committers change the project settings in their workspace.

Dani



From:        "Sasikanth B Ammanamanchi" <sasikanth.bharadwaj@xxxxxxxxxx>
To:        "Eclipse JDT Core developers list." <jdt-core-dev@xxxxxxxxxxx>
Date:        14.10.2016 07:51
Subject:        Re: [jdt-core-dev] Minimal-change policy?
Sent by:        jdt-core-dev-bounces@xxxxxxxxxxx




Same for me, so yes, oomph setup "could be" the culprit here. It may be picking up some other project's settings and applying them to jdt.core too. But wouldn't that show up as a change in the settings of the project if it does not match what's checked in?


Regards
Sasikanth

-----jdt-core-dev-bounces@xxxxxxxxxxxwrote: -----
To: "Eclipse JDT Core developers list." <jdt-core-dev@xxxxxxxxxxx>
From: Till Brychcy
Sent by:
jdt-core-dev-bounces@xxxxxxxxxxx
Date: 10/14/2016 01:59AM
Subject: Re: [jdt-core-dev] Minimal-change policy?


Am 13.10.2016 um 21:17 schrieb Stefan Xenos <sxenos@xxxxxxxxxx>:

> When you assume that JDT/Core committers use save actions for code clean-up,
> this assumption may not be shared with fellow committers.


Those save actions are part of the JDT core project settings. Not only do they happen by default, they are also extremely difficult to disable or circumvent since the "Save Actions" preference page for the JDT core project doesn't seem to work.

My workspace is manually setup (pre-oomph) and "save actions" are enabled for jdt.core, but with nothing selected.

For example, organize imports is not enabled in the commited settings of jdt.core:

https://github.com/eclipse/eclipse.jdt.core/blob/master/org.eclipse.jdt.core/.settings/org.eclipse.jdt.ui.prefs

sp_cleanup.organize_imports=false

(but it is on other jdt projects, e.g.  in jdt.debug.ui)

Maybe oomph turns them on somehow for jdt.core?





_______________________________________________
jdt-core-dev mailing list

jdt-core-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/jdt-core-dev
_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-core-dev



Back to the top