Re: [jdt-core-dev] Minimal-change policy?

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

I would like to point out that contributors may also used to press
Ctrt + Shift + O. By aligning the code base to the behavior of the JDT
formater you help these new contributors.

In Platform UI I really like that we have a huge number of incoming
contributions and I think this is related to the code cleanup we did
in the past, e.g., remove unnecessary whitespace, activate save
actions, etc.

I think our "Individual Contribution Activity:" looks really good
within the Eclipse Top-Level project:
https://projects.eclipse.org/projects/eclipse.platform.ui/who

Contributing to JDT core might be more complex than contributing to
Platform UI because of the project goal, but having good project
settings which does not work against new contributors is IMHO very
important to gain more community traction.

Best regards, Lars

On Fri, Oct 14, 2016 at 8:10 AM, Stefan Xenos <sxenos@xxxxxxxxxx> wrote:
> I just reproduced the steps needed to disable the post-save actions. You
> need to disable "organize imports" in the workspace settings (not the
> project settings)... and you may need to first enable post-save actions
> before you can click on the check box for organize imports to disable them.
>
>
> On Fri, Oct 14, 2016, 01:51 Sasikanth B Ammanamanchi
> <sasikanth.bharadwaj@xxxxxxxxxx> wrote:
>>
>> Same for me, so yes, oomph setup "could be" the culprit here. It may be
>> picking up some other project's settings and applying them to jdt.core too.
>> But wouldn't that show up as a change in the settings of the project if it
>> does not match what's checked in?
>>
>>
>> Regards
>> Sasikanth
>>
>> -----jdt-core-dev-bounces@xxxxxxxxxxx wrote: -----
>> To: "Eclipse JDT Core developers list." <jdt-core-dev@xxxxxxxxxxx>
>> From: Till Brychcy
>> Sent by: jdt-core-dev-bounces@xxxxxxxxxxx
>> Date: 10/14/2016 01:59AM
>> Subject: Re: [jdt-core-dev] Minimal-change policy?
>>
>>
>>
>> Am 13.10.2016 um 21:17 schrieb Stefan Xenos <sxenos@xxxxxxxxxx>:
>>
>> > When you assume that JDT/Core committers use save actions for code
>> > clean-up,
>> > this assumption may not be shared with fellow committers.
>>
>> Those save actions are part of the JDT core project settings. Not only do
>> they happen by default, they are also extremely difficult to disable or
>> circumvent since the "Save Actions" preference page for the JDT core project
>> doesn't seem to work.
>>
>>
>> My workspace is manually setup (pre-oomph) and "save actions" are enabled
>> for jdt.core, but with nothing selected.
>>
>> For example, organize imports is not enabled in the commited settings of
>> jdt.core:
>>
>>
>> https://github.com/eclipse/eclipse.jdt.core/blob/master/org.eclipse.jdt.core/.settings/org.eclipse.jdt.ui.prefs
>>
>> sp_cleanup.organize_imports=false
>>
>> (but it is on other jdt projects, e.g.  in jdt.debug.ui)
>>
>> Maybe oomph turns them on somehow for jdt.core?
>>
>>
>>
>>
>>
>> _______________________________________________
>> jdt-core-dev mailing list
>> jdt-core-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/jdt-core-dev
>>
>> _______________________________________________
>> jdt-core-dev mailing list
>> jdt-core-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/jdt-core-dev
>
>
> _______________________________________________
> jdt-core-dev mailing list
> jdt-core-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/jdt-core-dev



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com