[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jdt-core-dev] Merge the new index on monday?
|
Hi Stefan,
congratulations on this milestone reached.
a few comments:
Regarding the build: jobs get stuck after success during
"Recording test results"
Can we be sure that this is unrelated? Should we contact some
releng expert to be sure we know what's happening?
Several newindex jobs are affected, whereas JDT/UI jobs still
complete.
I wonder what's the state of running JDT/UI tests against your branch?
I remember you saying that you locally test this as well?
Another question: seeing changes around name environments:
could this create trouble for BETA_JAVA9 where we have different
changes in this area? Shouldn't block the push, just wondering
what additional tasks lie ahead of us here.
I just happened to see that a few new classes still lack the
necessary copyright header.
thanks,
Stephan
On 09/23/2016 09:47 PM, Stefan Xenos wrote:
It looks like the newindex branch just passed the full suite of JDT core unit tests for the first time (build output
here: https://hudson.eclipse.org/platform/job/eclipse.jdt.core-Gerrit/1611/console ).
Assuming the build shakes out okay, would anyone object if I merge it into master on monday?
If anyone is curious about the entire set of changes being merged, you can see a diff here:
https://git.eclipse.org/r/#/c/76660/
However, my plan is to merge the original branch using a merge commit - not a squash merge or rebase - that way the original
development history over the past year-and-a-half is preserved.
I figure a monday is a good time to do the big merge since everyone will be around to notice a broken build or regressions if they
occur.
- Stefan
_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-core-dev
