Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-core-dev] Javadoc compiler options default values will change


I applied your patch on JavadocQuickFixTest. Thanks!

Martin




Frederic Fusier/France/IBM@IBMFR
Sent by: jdt-core-dev-bounces@xxxxxxxxxxx

11/09/2005 10:48 PM

Please respond to
"Eclipse JDT Core developers list." <jdt-core-dev@xxxxxxxxxxx>

To
jdt-core-dev@xxxxxxxxxxx
cc
Subject
[jdt-core-dev] Javadoc compiler options default values will change






Due to bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=110964 fix,
some javadoc compiler options default value will change.

Here are the exact list of proposed changes:

JavaCore.COMPILER_PB_INVALID_JAVADOC_TAGS:
     - current default value = "enabled"
     - new default value = "disabled"
JavaCore.COMPILER_PB_INVALID_JAVADOC_TAGS__DEPRECATED_REF
     - current default value = "enabled"
     - new default value = "disabled"
JavaCore.COMPILER_PB_INVALID_JAVADOC_TAGS__NOT_VISIBLE_REF
     - current default value = "enabled"
     - new default value = "disabled"
JavaCore.COMPILER_PB_INVALID_JAVADOC_TAGS_VISIBILITY
     - current default value = "private"
     - new default value = "public"
JavaCore.COMPILER_PB_MISSING_JAVADOC_TAGS_VISIBILITY
     - current default value = "private"
     - new default value = "public"

I noticed that there are some impacts on JDT/UI tests which will be fixed
with following simple patch on
org.eclipse.jdt.ui.tests.quickfix.JavadocQuickFixTest.java:
(See attached file: JavadocQuickFixTest-patch.txt)

I plan to release these changes on JDT/Core early next week to target next
integration build.

If other JDT/Core clients get some troubles with these default values
changes,
please let me know as soon as possible, thanks

Cordialement/Regards,

Frédéric_______________________________________________
jdt-core-dev mailing list
jdt-core-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/jdt-core-dev

Index: JavadocQuickFixTest.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/JavadocQuickFixTest.java,v
retrieving revision 1.20
diff -u -r1.20 JavadocQuickFixTest.java
--- JavadocQuickFixTest.java	28 Sep 2005 17:00:07 -0000	1.20
+++ JavadocQuickFixTest.java	9 Nov 2005 21:41:24 -0000
@@ -62,6 +62,7 @@
 		options.put(DefaultCodeFormatterConstants.FORMATTER_TAB_CHAR, JavaCore.SPACE);
 		options.put(DefaultCodeFormatterConstants.FORMATTER_TAB_SIZE, "4");
 		options.put(JavaCore.COMPILER_PB_INVALID_JAVADOC, JavaCore.ERROR);
+		options.put(JavaCore.COMPILER_PB_INVALID_JAVADOC_TAGS, JavaCore.ENABLED);
 		options.put(JavaCore.COMPILER_PB_MISSING_JAVADOC_TAGS, JavaCore.ERROR);
 		options.put(JavaCore.COMPILER_PB_MISSING_JAVADOC_COMMENTS, JavaCore.ERROR);
 		options.put(JavaCore.COMPILER_PB_MISSING_JAVADOC_COMMENTS_OVERRIDING, JavaCore.ENABLED);

Back to the top